Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS X-Ray receiver uses both UDP and TCP endpoint #496

Closed
hencrice opened this issue Jul 23, 2020 · 1 comment · Fixed by #497
Closed

AWS X-Ray receiver uses both UDP and TCP endpoint #496

hencrice opened this issue Jul 23, 2020 · 1 comment · Fixed by #497
Labels
bug Something isn't working

Comments

@hencrice
Copy link
Contributor

Describe the bug
Recent commit incorrectly changed the UDP endpoint to TCPAddr. It also left out the TCP address in the proxy_server section.

Steps to reproduce
N/A

What did you expect to see?
N/A

What did you see instead?
N/A

What version did you use?
N/A

What config did you use?
N/A

Environment
N/A

Additional context
N/A
@hencrice hencrice added the bug Something isn't working label Jul 23, 2020
@hencrice
Copy link
Contributor Author

I'm fixing this

hencrice referenced this issue in hencrice/opentelemetry-collector-contrib Jul 23, 2020
@hencrice
Updated AWS X-Ray receiver Config to use udp
58d1bf6 
The receiver expsoses 2 endpoints:
1. An UDP endpoint for ingesting incoming spans
2. A TCP enpodint that serves as a local proxy between AWS and X-Ray SDK

Closes #496
hencrice referenced this issue in hencrice/opentelemetry-collector-contrib Jul 23, 2020
@hencrice
Updated AWS X-Ray receiver Config to use udp
b13b60c 
The receiver exposes 2 endpoints:
1. An UDP endpoint for ingesting incoming spans
2. A TCP enpodint that serves as a local proxy between AWS and X-Ray SDK

Closes #496
hencrice referenced this issue in hencrice/opentelemetry-collector-contrib Jul 23, 2020
@hencrice
Updated AWS X-Ray receiver Config to use udp
86b7606 
The receiver exposes 2 endpoints:
1. An UDP endpoint for ingesting incoming spans
2. A TCP endpoint that serves as a local proxy between AWS and X-Ray SDK

This PR updates the `Config` to correctly store both.

Closes #496
hencrice referenced this issue in hencrice/opentelemetry-collector-contrib Jul 23, 2020
@hencrice
Updated AWS X-Ray receiver Config to use udp
93f5cb2 
The receiver exposes 2 endpoints:
1. An UDP endpoint for ingesting incoming spans
2. A TCP endpoint that serves as a local proxy between AWS and X-Ray SDK

This PR updates the `Config` to correctly store both.

Closes #496
@hencrice hencrice mentioned this issue Jul 23, 2020
Merged
bogdandrutu pushed a commit that referenced this issue Jul 23, 2020
@hencrice
Updated AWS X-Ray receiver Config to use udp (#497)
03c7469 
The receiver exposes 2 endpoints:
1. An UDP endpoint for ingesting incoming spans
2. A TCP endpoint that serves as a local proxy between AWS and X-Ray SDK

This PR updates the `Config` to correctly store both.

Closes #496
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@tigrannajaryan
Use specific commit hash in dependency (#496)
9f801c5 
We previously had a broken dependency that was referring
to non-existing version 0.2.0. This is now causing problems
whenever go attempts to resolve latest version.

Pinning to specific commit should hopefully fix the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated AWS X-Ray receiver Config to use udp hencrice/opentelemetry-collector-contrib
1 participant
@hencrice