Updated AWS X-Ray receiver Config to use udp #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The receiver exposes 2 endpoints: 1. An UDP endpoint for ingesting incoming spans 2. A TCP endpoint that serves as a local proxy between AWS and X-Ray SDK This PR updates the `Config` to correctly store both. Closes #496
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 85.93% 85.92% -0.02%
==========================================
Files 187 187
Lines 10055 10058 +3
==========================================
+ Hits 8641 8642 +1
- Misses 1094 1095 +1
- Partials 320 321 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@bogdandrutu @james-bebbington Could you guys review this fix? Thanks! |
bogdandrutu
reviewed
Jul 23, 2020
bogdandrutu
approved these changes
Jul 23, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Workers were unnecessary complication and did not provide any measurable performance gains. In addition they were decoupling receiver from subsequent processors which makes difficult upcoming implementation of backpressure in the pipeline (from processors to receivers). Test results that shows that worker give no performance benefits (any differences are within the measurement error margin): Without workers (this commit): Test |Result|Duration|CPU Avg%|CPU Max%|RAM Avg MiB|RAM Max MiB|Sent Items|Received Items| ----------------------------------------|------|-------:|-------:|-------:|----------:|----------:|---------:|-------------:| Trace10kSPS/OpenCensus |PASS | 16s| 22.7| 25.9| 37| 45| 149880| 149880| With workers (latest `master` branch): Test |Result|Duration|CPU Avg%|CPU Max%|RAM Avg MiB|RAM Max MiB|Sent Items|Received Items| ----------------------------------------|------|-------:|-------:|-------:|----------:|----------:|---------:|-------------:| Trace10kSPS/OpenCensus |PASS | 16s| 23.3| 24.9| 37| 46| 149920| 149920|
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* opentelemetry collector exporter - missing load test - missing resources * fix review comments. * add test for each SpanKind and Attribute Type. * rename otelcol to otlp * move exporter/trace/otlp to exporters/otlp * more review comments. * add alignment test. * pass context to uploadSpans
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The receiver exposes 2 endpoints:
This PR updates the
Configto correctly store both.Link to tracking Issue:
Closes #496
Testing:
Unit tests updated
Documentation:
README.md updated