Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiver creator provides unsupported endpoint config field #7381

Closed
rmfitzpatrick opened this issue Jan 25, 2022 · 8 comments
Closed

Receiver creator provides unsupported endpoint config field #7381

rmfitzpatrick opened this issue Jan 25, 2022 · 8 comments
Labels
bug Something isn't working receiver/receivercreator

Comments

@rmfitzpatrick
Copy link
Contributor

Describe the bug
Not all receivers support endpoint and the receiver creator assumes this isn't the case. Adding it to the discovered config will lead to unmarshalling errors:

failed to start receiver	{"kind": "receiver", "name": "receiver_creator", "receiver": "prometheus", "error": "failed to load template config: error reading receivers configuration for \"prometheus\": prometheus receiver failed to parse config: 1 error(s) decoding:\n\n* '' has invalid keys: endpoint"}
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/receivercreator.(*observerHandler).OnAdd
@rmfitzpatrick rmfitzpatrick added the bug Something isn't working label Jan 25, 2022
@rmfitzpatrick
Copy link
Contributor Author

fwiw I will try to resolve this issue when next free.

@awx-fuyuanchu
Copy link

Any updates?

@CoderPoet
Copy link

I have this problem too

@matianjun1
Copy link
Contributor

same for kafkametrics with receiver_creator

failed to start receiver	{"kind": "receiver", "name": "receiver_creator", "pipeline": "metrics", "receiver": "kafkametrics", "error": "failed to load template config: 1 error(s) decoding:\n\n* '' has invalid keys: endpoint"}

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 12, 2022
@narmendariz
Copy link

@rmfitzpatrick able to circle back on this one soon?

@github-actions
Copy link
Contributor

Pinging code owners for receiver/receivercreator: @rmfitzpatrick. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme
Copy link
Contributor

atoulme commented Mar 4, 2023

Closing as completed.

@atoulme atoulme closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/receivercreator
Projects
None yet
Development

No branches or pull requests

6 participants