SignalFx exporter: Add host metadata synchronization #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
sfx-host-metadata
branch
from
bd6acb4
to
21224e0
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
sfx-host-metadata
branch
2 times, most recently
from
55a3c8f
to
e3ca399
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
sfx-host-metadata
branch
2 times, most recently
from
a914693
to
0235014
Compare
Codecov Report
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 89.59% 89.63% +0.03%
==========================================
Files 272 273 +1
Lines 13240 13302 +62
==========================================
+ Hits 11863 11923 +60
- Misses 1011 1013 +2
Partials 366 366
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
as discussed with @jrcamp it will be changes to use cloud unique id instead of host |
dmitryax
force-pushed
the
sfx-host-metadata
branch
3 times, most recently
from
cd5b0b7
to
40a58bf
Compare
dmitryax
force-pushed
the
sfx-host-metadata
branch
from
40a58bf
to
252f0c9
Compare
|
@dmitryax I think the PR has become too big. I think it'd be good to break it up at least into two pieces, one being stuff that came from smart agent that's already been vetted there and the second is new code that may need a closer look. |
dmitryax
force-pushed
the
sfx-host-metadata
branch
from
252f0c9
to
34982aa
Compare
dmitryax
force-pushed
the
sfx-host-metadata
branch
2 times, most recently
from
9436d96
to
71c3522
Compare
jrcamp
reviewed
Sep 25, 2020
jrcamp
reviewed
Sep 25, 2020
|
lgtm after the assert thing is fixed and #1100 is merged (should be soon) so that can be removed here. |
dmitryax
force-pushed
the
sfx-host-metadata
branch
from
95c6798
to
3eb42a1
Compare
This change introduces host metadata updates functionality in Signalfx exporter. Synchronization happens once first metric batch is received. It looks for dimensions set by resourcedetection processor
dmitryax
force-pushed
the
sfx-host-metadata
branch
from
3eb42a1
to
78987ba
Compare
|
@jrcamp , PR rebased |
jrcamp
approved these changes
Sep 28, 2020
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change introduces host metadata updates functionality in Signalfx exporter. Synchronization happens once first metric batch is received. It looks for dimensions set by resourcedetection processor