Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signalfx exporter: Port host utilities from github.com/signalfx/golib #1118

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 24, 2020

All the files ported as is (or with minor modifications) from https://github.com/signalfx/golib/tree/master/metadata/hostmetadata.

The utilities will be used for host metadata synchronization.

This is the first part of PR: #1039

The utilities will be used for host metadata synchronization.
@dmitryax dmitryax requested a review from a team as a code owner September 24, 2020 17:21
@project-bot project-bot bot added this to In progress in Collector Sep 24, 2020
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass

Collector automation moved this from In progress to Reviewer approved Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1118 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1118      +/-   ##
==========================================
+ Coverage   88.94%   89.01%   +0.07%     
==========================================
  Files         258      260       +2     
  Lines       12330    12413      +83     
==========================================
+ Hits        10967    11050      +83     
  Misses       1011     1011              
  Partials      352      352              
Flag Coverage Δ
#integration 75.42% <ø> (-0.11%) ⬇️
#unit 88.07% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/hostmetadata/host.go 100.00% <100.00%> (ø)
...porter/signalfxexporter/hostmetadata/host_linux.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cea0af...e14243e. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 3b94b17 into open-telemetry:master Sep 24, 2020
Collector automation moved this from Reviewer approved to Done Sep 24, 2020
@dmitryax dmitryax deleted the host-metadata-1 branch September 29, 2020 22:51
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Add new propagators package

* Move B3 propagator to propagators

Update all `api/trace` dependencies in the propagator.

Export the isDeferred and isDebug methods of the SpanContext. These are
needed by the B3 propagator to track trace state.

* Move W3C trace context propagator to propagators

* Update package docs with supported encodings

* Move unified propagators code to own file

* Update b3 exported documentation

* Update trace_context exported documentation

* Add code examples for B3 propagator

* Add TraceContext example code

* Remove internal package

Move common testing declarations to the propagators_test.go file.

* Add changes to Changelog

* Add test to check default propagators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants