feat: add datadog trace translation helpers and tests #1208

ericmustin · 2020-10-05T21:34:19Z

Description: This PR adds utilities to the datadog exporter to translate internal trace representation to Datadog format. It represents the first of two PRs for the work contained in #1203. It builds on top of current master branch.

The 2nd PR for this work will follow, and will add functionality to export traces to Datadog's API Intake.

This PR Split was requested by @tigrannajaryan and hopefully should make code review a bit less cumbersome. However if there are any questions or changes to the PR format needed, please let me know.

For the trace translation we are not relying on OpenCensus helpers as other exporters do based on this Gitter thread.

Testing: There are unit tests for the different methods and helper methods within the translation code. ~~Fwiw everything passes locally, on the linked PR there appeared to be some compilation issues for windows due to a dependancy. I can investigate this more if it persist.~~ transient issue, disregard

Documentation: Currently the trace exporter code isn't contained in this PR, but when it is added (in a subsequent PR), it's usage will be documented in the testdata/config.yaml and example/config.yaml samples.

example trace

codecov · 2020-10-05T21:48:47Z

Codecov Report

Merging #1208 into master will increase coverage by 0.66%.
The diff coverage is 79.90%.

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   88.98%   89.65%   +0.66%     
==========================================
  Files         284      287       +3     
  Lines       13804    14097     +293     
==========================================
+ Hits        12283    12638     +355     
+ Misses       1162     1076      -86     
- Partials      359      383      +24

Flag	Coverage Δ
#integration	`75.68% <ø> (?)`
#unit	`88.82% <79.90%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
exporter/datadogexporter/model.go	`73.68% <73.68%> (ø)`
exporter/datadogexporter/translate_traces.go	`80.50% <80.50%> (ø)`
receiver/k8sclusterreceiver/watcher.go	`95.29% <0.00%> (-2.36%)`	⬇️
internal/common/testing/container/container.go	`72.97% <0.00%> (ø)`
receiver/dockerstatsreceiver/docker.go	`92.30% <0.00%> (+39.05%)`	⬆️
receiver/dockerstatsreceiver/receiver.go	`96.82% <0.00%> (+49.20%)`	⬆️
receiver/redisreceiver/receiver.go	`87.50% <0.00%> (+87.50%)`	⬆️
receiver/redisreceiver/client.go	`100.00% <0.00%> (+100.00%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9786c16...b355df1. Read the comment docs.

merge master

go.sum

merge upstream

ericmustin · 2020-10-07T21:41:43Z

@rmfitzpatrick lmk if any questions about ddog format, happy to clarify anything, any feedback is much appreciated as i'm quite new to the collector

exporter/datadogexporter/go.mod

rmfitzpatrick · 2020-10-12T14:29:56Z

exporter/datadogexporter/translate_traces.go

+	keySpanName         string = "span.name"
+	httpStatusCode      string = "http.status_code"
+	httpMethod          string = "http.method"
+	httpRoute           string = "http.route"


These are available as http attribute names: https://github.com/open-telemetry/opentelemetry-collector/blob/c8622d2353485e8aa9ebde351feee431fc46f2f9/translator/conventions/opentelemetry.go#L183

ah, nice, updated these to rely on convention constants when available.

exporter/datadogexporter/translate_traces.go

rmfitzpatrick · 2020-10-12T15:05:13Z

exporter/datadogexporter/translate_traces.go

+
+	attrs := resource.Attributes()
+	if attrs.Len() == 0 {
+		return tracetranslator.ResourceNoAttrs, datadogTags


Curious why this and ResourceNotSet would be preferable to ResourceNoServiceName as a Datadog service name.

There's no real strong beliefs here, I think I was mostly mimicking the behavior of zipkin's translation logic, here: https://github.com/open-telemetry/opentelemetry-collector/blob/035aa5cf6c92678c3f8362d6916e18444a8250fb/translator/trace/zipkin/zipkinv2_to_traces.go#L353-L360

That being said it's less to worry about to just have a canonical "There's no resource service.name tag", so I've followed your advice here and just simplified to return ResourceNoServiceName in either case.

rmfitzpatrick · 2020-10-12T15:12:45Z

exporter/datadogexporter/translate_traces.go

+}
+
+// converts Traces into an array of datadog trace payloads grouped by env
+func ConvertToDatadogTd(td pdata.Traces, cfg *Config, globalTags []string) ([]*pb.TracePayload, error) {


Where do these :-separated global tags come from?

These are passed in as a config option in setup

opentelemetry-collector-contrib/exporter/datadogexporter/config.go

Line 97 in 187482f

Tags []string `mapstructure:"tags"`

, basically an array of arbitrary list of global tags that user's want to set on every span. So, "feature_flag:xyz, cloud_provider:alibaba" or anything along those lines.

rmfitzpatrick · 2020-10-12T15:15:41Z

@ericmustin this looks good to me, though I do have a few nits and questions.

ericmustin · 2020-10-12T15:21:29Z

@rmfitzpatrick ty for taking a look, feedback is super reasonable and makes sense, i should be able to address/incorporate each point mentioned relatively quickly

merge upstream

ericmustin · 2020-10-12T21:35:48Z

@rmfitzpatrick tried to address all the feedback/questions here, lmk if anything else pops up, appreciate the review.

tigrannajaryan · 2020-10-15T13:15:11Z

It looks like master is failing after this PR was merged: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib?branch=master

How did this PR pass the build?

tigrannajaryan · 2020-10-15T13:20:30Z

@ericmustin I am going to revert this commit to fix the master build while you figure out what is the right solution. Please note that we don't allow CGO in the Collector.

ericmustin · 2020-10-15T13:20:52Z

@tigrannajaryan I believe the windows-test PR was merged right around the same time #1228

The followup PR to this ( #1266) also fixes master as I've marked the files causing issues bc off gcc/cgo issues to not build on windows. If you'd like I can separate that out so that we can roll forward here?

…d tests (open-telemetry#1208)" This reverts commit 8d6f04c. The "master" build was failing: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/4960/workflows/85f1e1cf-60fd-44d1-88f5-2c86884038c0/jobs/36766 It appears it was because the new commit needs CGO. We don't allow CGO in the Collector. I am reverting this temporarily until a proper solution is found.

@tigrannajaryan

This PR adds flushing+export of traces and trace-related statistics to the `datadogexporter`, as well as some very minor changes to the translation of internal traces into Datadog format. It represents the second of two PRs for the work contained in #1203. It builds on top of current master branch, and follows up to the work [done here](#1208). The final PR explicitly enabling The Datadog exporter will follow, and will allow users to export traces to Datadog's API Intake. This PR Split was requested by @tigrannajaryan and hopefully should make code review a bit less cumbersome. However if there are any questions or changes to the PR format needed, please let me know. **Testing:** There are unit tests for the different methods and helper methods within the export code. **Documentation:** Appropriate usage, including best practices for which processors to also enable, has been documented in the README, `testdata/config.yaml` and `example/config.yaml` samples. **Notes**: This PR includes a trace exporter for non-windows environments only (metrics are fine in windows, just traces that are the issue), due to reasons explained in this pr #1274 . tl;dr is our trace export code for windows env would rely on CGO for now, which is not permitted in the collector

@tigrannajaryan

This PR adds flushing+export of traces and trace-related statistics to the `datadogexporter`, as well as some very minor changes to the translation of internal traces into Datadog format. It represents the second of two PRs for the work contained in open-telemetry#1203. It builds on top of current master branch, and follows up to the work [done here](open-telemetry#1208). The final PR explicitly enabling The Datadog exporter will follow, and will allow users to export traces to Datadog's API Intake. This PR Split was requested by @tigrannajaryan and hopefully should make code review a bit less cumbersome. However if there are any questions or changes to the PR format needed, please let me know. **Testing:** There are unit tests for the different methods and helper methods within the export code. **Documentation:** Appropriate usage, including best practices for which processors to also enable, has been documented in the README, `testdata/config.yaml` and `example/config.yaml` samples. **Notes**: This PR includes a trace exporter for non-windows environments only (metrics are fine in windows, just traces that are the issue), due to reasons explained in this pr open-telemetry#1274 . tl;dr is our trace export code for windows env would rely on CGO for now, which is not permitted in the collector

@tigrannajaryan

* Add API key validation (#1216) Adds API key validation to the Datadog metrics exporter. When created, the Datadog metrics exporter now sends a requests to the `/api/v1/validate` endpoint of the Datadog backend to check that the configured API key is valid. If it's not, a warning log is emitted. Tests were amended to take into account that validation call. Test utils were added to mock an HTTP server that performs validation. * sapmexporter: make span source attribute and destination dimension names configurable (#1286) If dimension names are being translated in the signalfxexporter then the map values should be set to the signalfx names. Ideally we can sync to OT dimension names with translation being done on the backend (the default). * Update README (#1294) * Release v0.13.0 (#1295) * Remove duplicate definition of cloud providers with core conventions (#1288) * Remove duplicate definition of cloud providers Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix more duplicate usage of the cloud providers semconv Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Splunkhec receiver metrics (#1276) Adds the ability for Splunk HEC to ingest metrics. This is a follow up to #1268 which adds the ability to ingest logs. * Add jpkrohling as an approver (#1296) * Remove pjanotti from maintainers (#1300) * Auto assign approver and maintainers to PRs (#1301) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add codeowners to ensure components are assigned to the appropriate reviewers (#1304) This is the initial list extracted from README. * Moved the groupbytrace processor to contrib (#1179) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add codeowners for interanl components (#1307) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Small fixes to CODEOWNERS (#1312) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> **Description:** This PR changes the CODEOWNERS in a couple of aspects: 1. Fixed the order of the directories, so that 'internal' comes after 'extension' 1. Fixed the name of a few components 1. Added missing components and directories Verified with: ``` for component in exporter extension processor receiver; do ls ${component}/ -1 > /tmp/${component}.txt grep ${component} .github/CODEOWNERS | awk -F\/ '{print $2}' > /tmp/${component}-codeowners.txt diff /tmp/${component}.txt /tmp/${component}-codeowners.txt done ``` Result of the script before this PR: ```diff 11d10 < loadbalancingexporter 2c2 < jmxmetricsextension --- > jmxmetrics 1d0 < groupbytraceprocessor 5c4 < routingprocessor --- > routing ``` * Update collector version in groupbytraceprocessor (#1309) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update dependabot to ensure all projects are added (#1303) * Update dependabot to ensure all projects are added Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update dependabot.yml * Do not run tests/lint/etc for all component tags (e.g. tag testbed/v0.13.0) (#1298) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * tests: increase TestTrace10kSPS memory limits (#1314) * Bump k8s.io/client-go in /receiver/k8sclusterreceiver (#1323) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.19.2 to 0.19.3. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.19.2...v0.19.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/aliyun/aliyun-log-go-sdk (#1321) Bumps [github.com/aliyun/aliyun-log-go-sdk](https://github.com/aliyun/aliyun-log-go-sdk) from 0.1.13 to 0.1.14. - [Release notes](https://github.com/aliyun/aliyun-log-go-sdk/releases) - [Commits](aliyun/aliyun-log-go-sdk@v0.1.13...v0.1.14) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump go.opencensus.io in /processor/groupbytraceprocessor (#1320) Bumps [go.opencensus.io](https://github.com/census-instrumentation/opencensus-go) from 0.22.4 to 0.22.5. - [Release notes](https://github.com/census-instrumentation/opencensus-go/releases) - [Commits](census-instrumentation/opencensus-go@v0.22.4...v0.22.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump k8s.io/client-go from 0.19.2 to 0.19.3 in /internal/k8sconfig (#1318) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.19.2 to 0.19.3. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.19.2...v0.19.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add more @elastic folks to codeowners (#1313) In answer to open-telemetry#1304 (comment) add two more codeowners for the Elastic exporter. * Add contrib approvers as owners to all the components. (#1325) Without this change if there is a listed owner with write permission in the component owners list, the contrib approvers will lose their power see #1316. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Bump github.com/aws/aws-sdk-go in /internal/awsxray (#1316) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.9 to 1.35.10. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.9...v1.35.10) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/aws/aws-sdk-go in /internal/awsxray/testdata/sampleapp (#1317) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.9 to 1.35.10. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.9...v1.35.10) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Clarify PR reviewing and facilitating (#1315) We recently introduced the automatic assignments of PRs to reviewers and to facilitators. This change explains the process. * Handle nil references from the kubelet API (#1326) * Update to latest collector, update deprecated calls (#1308) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * signalfx Receiver: Better Pipeline Error Handling (#1329) If logs aren't configured and events are sent, return a clear error response instead of panicing. Vice-versa for metrics. * [datadogexporter] Improve hostname resolution (#1285) Improve system hostname detection for the Datadog exporter. This PR: - Moves config and host code to their own packages to avoid dependency cycles - Adds hostname validation - Adds fully qualified domain name hostname resolution on some platforms - Adds support for caching hostname Added unit tests, tested on an end to end test environment with the component activated. Documentation was added to all public functions. * Temporarily remove dmitryax from PR facilitators (#1330) dmitryax will be unavailable for a while, removing him from the list of PR facilitators. * Update otel collector, fix breaking change for renaming TracesConsumer (#1328) * Update otel collector, fix breaking change for renaming TracesConsumer Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * More fixes of usages Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add batchpertrace library (#1257) Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Adds a library that will split the incoming batch into several batches, one per trace. **Link to tracking Issue:** Closes #1235. * Fix the link to the release notes (#1327) * Datadog trace flushing/export (#1266) This PR adds flushing+export of traces and trace-related statistics to the `datadogexporter`, as well as some very minor changes to the translation of internal traces into Datadog format. It represents the second of two PRs for the work contained in open-telemetry#1203. It builds on top of current master branch, and follows up to the work [done here](open-telemetry#1208). The final PR explicitly enabling The Datadog exporter will follow, and will allow users to export traces to Datadog's API Intake. This PR Split was requested by @tigrannajaryan and hopefully should make code review a bit less cumbersome. However if there are any questions or changes to the PR format needed, please let me know. **Testing:** There are unit tests for the different methods and helper methods within the export code. **Documentation:** Appropriate usage, including best practices for which processors to also enable, has been documented in the README, `testdata/config.yaml` and `example/config.yaml` samples. **Notes**: This PR includes a trace exporter for non-windows environments only (metrics are fine in windows, just traces that are the issue), due to reasons explained in this pr open-telemetry#1274 . tl;dr is our trace export code for windows env would rely on CGO for now, which is not permitted in the collector * Logzio exporter impl (#1161) Added a logz.io traces exporter **Link to tracking Issue**: #686 **Testing**: Added test for each of the components in the new exporter **Documentation**: Added a readme specifying how to use the exporter and its parameters with an example. * Add the notion of unstable components and unstable executable (#1299) The list of experimental components is defined in unstable_components_enabled.go. These components are only enabled when enable_unstable build tag is defined. We define this tag and produce an executable named otelcontribcol_unstable_$(GOOS)_$(GOARCH)$(EXTENSION) when `make otelcontribcol-unstable` is invoked. For now the new executable is not used anywhere. Next I will look into modifying the testbed to call the new unstable executable for certain tests. To verify that the unstable build functionality is enabled I added stanzareceiver to the list of unstable components and manually verified that it is indeed enabled in the unstable executable but is not available in the regular otelcontribcol executable. Contributes to open-telemetry#873 * JMX Metric Extension: Initial implementation (#1182) * Add JMX Metric Extension implementation * rename package to jmxmetricextension * jmxmetricextension s/metrics/metric * jmx metrics: fix prometheus typo * jmx metrics: capitalize acronyms * jmx metrics: clarify interval * Enable stale PR action (#1341) To help reviewers and authors remember to make progress on PR this action will mark PRs as stale after inactivity of 7 days and will close the PR after 7 more days of inactivity. * [datadogexporter] Enable traces on Windows (#1340) * Re-enable traces code on Windows Use a custom-made version of the Datadog Agent repository that greatly reduces the number of dependencies needed and removes the osext one that depends on CGo * Address linter issue * Empty commit to retrigger CI * Build traces flush/export code on Windows * Add kind type to root span to fix the empty parentID problem (#1338) * Add kind type to root span to fix the empty parentID problem * Set kind type for root span in Xray receiver * Update receiver/awsxrayreceiver/internal/translator/translator.go Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * [awsecscontainermetrics] receiver- Update README (#1358) * [awsecscontainermetrics] receiver- Update README Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com> * Use full form of metric units Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com> * Add timer support for statsD receiver (#1335) * [datadogexporter] Add Datadog exporter to the otelcontribcol binary (#1352) * Add datadogexporter to the binary * Disable environment variables They don't work; we will revisit it in the future * [datadogexporter] Update go-datadog-api.v2 dependency to v2.30.0 (#1365) * [signalfx_correlation] Add signalfx_correlation exporter skeleton (#1332) * [signalfx_correlation] Add signalfx_correlation exporter skeleton This is for moving the correlation out of sapmexporter into a dedicated exporter so that the correlation can be used even when sapm isn't (for example, on an agent that is exporting in otlp to a gateway instead of sapm.) * fix readme * [awsemfexporter] Restructure Metric Translator Logic (#1353) * Restructure buildCWMetric logic (#1) * Restructure code to remove duplicated logic * Update format * Improve function and variable names * Extract logic for dimension creation and add test * Implement minor fixes * Remove changes to go.sum * Implement tests for getCWMetrics * Implement tests for buildCWMetric * Format metric_translator_test.go * Run with gofmt -s * Disregard ordering of dimensions in test case * Perform dimension equality checking as a helper function * Setting the tlsconfig InsecureSkipVerify using NoVerifySSL (#1350) Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com> Co-authored-by: Jay Camp <jay.r.camp@gmail.com> Co-authored-by: Steve Flanders <sflanders@splunk.com> Co-authored-by: Jeff Cheng <jcheng@signalfx.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Antoine Toulme <atoulme@users.noreply.github.com> Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Co-authored-by: Paulo Janotti <pjanotti@splunk.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Eric Mustin <mustin.eric@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Wilkins <axw@elastic.co> Co-authored-by: Pablo Collins <pablo.collins@gmail.com> Co-authored-by: Ben Keith <benkeith@splunk.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com> Co-authored-by: Yogev Mets <yogev.metzuyanim@logz.io> Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com> Co-authored-by: John <59711343+JohnWu20@users.noreply.github.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Rayhan Hossain (Mukla.C) <hossain.rayhan@outlook.com> Co-authored-by: Gavin Zhang (Kunyuan Zhang) <31523962+gavindoudou@users.noreply.github.com> Co-authored-by: shreyas Darwhatkar <67069455+darwhs@users.noreply.github.com>

@tigrannajaryan

This PR adds flushing+export of traces and trace-related statistics to the `datadogexporter`, as well as some very minor changes to the translation of internal traces into Datadog format. It represents the second of two PRs for the work contained in open-telemetry#1203. It builds on top of current master branch, and follows up to the work [done here](open-telemetry#1208). The final PR explicitly enabling The Datadog exporter will follow, and will allow users to export traces to Datadog's API Intake. This PR Split was requested by @tigrannajaryan and hopefully should make code review a bit less cumbersome. However if there are any questions or changes to the PR format needed, please let me know. **Testing:** There are unit tests for the different methods and helper methods within the export code. **Documentation:** Appropriate usage, including best practices for which processors to also enable, has been documented in the README, `testdata/config.yaml` and `example/config.yaml` samples. **Notes**: This PR includes a trace exporter for non-windows environments only (metrics are fine in windows, just traces that are the issue), due to reasons explained in this pr open-telemetry#1274 . tl;dr is our trace export code for windows env would rely on CGO for now, which is not permitted in the collector

…ent protocols (#1208) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

- Test by span attributes added by processors in the order they were registered. Signed-off-by: Hui Kang <kangh@us.ibm.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

feat: add datadog trace translation helpers and tests

0f8a489

ericmustin requested a review from a team as a code owner October 5, 2020 21:34

project-bot bot added this to In progress in Collector Oct 5, 2020

ericmustin added 3 commits October 6, 2020 00:29

tests: add more unit tests for code cov

de34c9e

tests: additional unit tests for codecov

d350872

Merge branch 'master' into trace_translation

a39c4e5

merge master

tigrannajaryan reviewed Oct 6, 2020

View reviewed changes

go.sum Outdated Show resolved Hide resolved

tigrannajaryan assigned rmfitzpatrick Oct 6, 2020

ericmustin added 3 commits October 6, 2020 15:44

dont modify go.sum since ddog exporter is not enabled

b355df1

test trace state and nil cases better

7179cb1

Merge branch 'master' into trace_translation

e81a052

merge upstream

ericmustin requested a review from tigrannajaryan October 8, 2020 18:29

rmfitzpatrick reviewed Oct 12, 2020

View reviewed changes

exporter/datadogexporter/go.mod Outdated Show resolved Hide resolved

rmfitzpatrick reviewed Oct 12, 2020

View reviewed changes

exporter/datadogexporter/translate_traces.go Outdated Show resolved Hide resolved

rmfitzpatrick reviewed Oct 12, 2020

View reviewed changes

rmfitzpatrick moved this from In progress to Review in progress in Collector Oct 12, 2020

ericmustin added 2 commits October 12, 2020 23:09

Merge branch 'master' into trace_translation

4210fbf

merge upstream

exporter/datadog: update version and implement feedback

a9141ab

ericmustin requested a review from rmfitzpatrick October 12, 2020 21:36

rmfitzpatrick approved these changes Oct 13, 2020

View reviewed changes

rmfitzpatrick moved this from Review in progress to Reviewer approved in Collector Oct 13, 2020

bogdandrutu approved these changes Oct 14, 2020

View reviewed changes

bogdandrutu merged commit 8d6f04c into open-telemetry:master Oct 14, 2020

Collector automation moved this from Reviewer approved to Done Oct 14, 2020

ericmustin mentioned this pull request Oct 14, 2020

Datadog trace flushing/export #1266

Merged

dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021

Refactor jaeger receiver config to allow different configs for differ…

992cdc5

…ent protocols (#1208) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

codeboten pushed a commit that referenced this pull request Nov 23, 2022

Restore metrics in django (#1208)

7382b5e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add datadog trace translation helpers and tests #1208

feat: add datadog trace translation helpers and tests #1208

ericmustin commented Oct 5, 2020 •

edited

Loading

codecov bot commented Oct 5, 2020 •

edited

Loading

ericmustin commented Oct 7, 2020

rmfitzpatrick Oct 12, 2020

ericmustin Oct 12, 2020

rmfitzpatrick Oct 12, 2020

ericmustin Oct 12, 2020

rmfitzpatrick Oct 12, 2020

ericmustin Oct 12, 2020

rmfitzpatrick commented Oct 12, 2020

ericmustin commented Oct 12, 2020 •

edited

Loading

ericmustin commented Oct 12, 2020

tigrannajaryan commented Oct 15, 2020

tigrannajaryan commented Oct 15, 2020

ericmustin commented Oct 15, 2020

feat: add datadog trace translation helpers and tests #1208

feat: add datadog trace translation helpers and tests #1208

Conversation

ericmustin commented Oct 5, 2020 • edited Loading

codecov bot commented Oct 5, 2020 • edited Loading

Codecov Report

ericmustin commented Oct 7, 2020

rmfitzpatrick Oct 12, 2020

Choose a reason for hiding this comment

ericmustin Oct 12, 2020

Choose a reason for hiding this comment

rmfitzpatrick Oct 12, 2020

Choose a reason for hiding this comment

ericmustin Oct 12, 2020

Choose a reason for hiding this comment

rmfitzpatrick Oct 12, 2020

Choose a reason for hiding this comment

ericmustin Oct 12, 2020

Choose a reason for hiding this comment

rmfitzpatrick commented Oct 12, 2020

ericmustin commented Oct 12, 2020 • edited Loading

ericmustin commented Oct 12, 2020

tigrannajaryan commented Oct 15, 2020

tigrannajaryan commented Oct 15, 2020

ericmustin commented Oct 15, 2020

ericmustin commented Oct 5, 2020 •

edited

Loading

codecov bot commented Oct 5, 2020 •

edited

Loading

ericmustin commented Oct 12, 2020 •

edited

Loading