[exporter/humio] Don't rely on [SpanKind|StatusCode].String method #16018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on the [SpanKind|StatusCode].String() for spans encoding. The method is not supposed to be used for this purpose.
dmitryax
force-pushed
the
humio-exporter-dont-use-string
branch
from
eb836e0
to
4e2ac86
Compare
bogdandrutu
approved these changes
Nov 1, 2022
|
Replaced by #16021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on the [SpanKind|StatusCode].String() for spans encoding as Humio events. The method is not supposed to be used for this purpose.
This PR is one of prerequisites for updating output of the [SpanKind|StatusCode].String() method without breaking functionality of its consumers open-telemetry/opentelemetry-collector#6250