[pdata] Update values returned by all String methods of enum types #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
force-pushed
the
update-other-names
branch
4 times, most recently
from
2d9ad3c
to
d60e6ef
Compare
dmitryax
force-pushed
the
update-other-names
branch
from
d60e6ef
to
3079b88
Compare
Codecov ReportBase: 91.86% // Head: 91.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6250 +/- ##
==========================================
+ Coverage 91.86% 91.93% +0.06%
==========================================
Files 237 237
Lines 13620 13694 +74
==========================================
+ Hits 12512 12589 +77
+ Misses 879 876 -3
Partials 229 229
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
force-pushed
the
update-other-names
branch
from
3079b88
to
aa32267
Compare
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
Update values returned by all String methods of enum types to a consistent short form representing the enum identifier
dmitryax
force-pushed
the
update-other-names
branch
from
aa32267
to
e950650
Compare
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
|
@bogdandrutu this is ready for review |
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Nov 2, 2022
[SpanKind|StatusCode].String() will be changed to return different string values. This change replaces existing method calls with contrib internal functions to avoid breaking changes when open-telemetry/opentelemetry-collector#6250 is merged
bogdandrutu
approved these changes
Nov 4, 2022
|
@bogdandrutu curious why this repo started creating merge commits recently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update values returned by all String methods of enum types to a consistent short form representing the enum identifier.
The following methods don't rely on proto enum constant names anymore and return values consistent with other pdata enums:
plog.SeverityNumber.String() now returns:
ptrace.SpanKind.String() now returns:
ptrace.StatusCode.String() now returns:
This change represents the approach A described in #6251