-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update honeycomb exporter to use internal data format #1689
Conversation
This has several breaking changes to the events produced by the exporter - service_name -> service.name - process.hostname -> host.name - process.pid -> opencensus.pid (for census users) - opencensus.start_timestamp -> opencensus.starttime - has_remote_parent was removed - source_format was removed New features - other span_kinds are now supported (consumer, producer, internal)
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
==========================================
+ Coverage 89.41% 89.47% +0.06%
==========================================
Files 370 370
Lines 18141 18114 -27
==========================================
- Hits 16221 16208 -13
+ Misses 1430 1418 -12
+ Partials 490 488 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can you please fix the build? |
add test coverage add library information to events
@MikeGoldsmith @lizthegrey I may have made a mistake, I am not sure why you were not added as reviewer. If this is not ok for you please file a revert and I will immediately approve that. Sorry for this |
Thanks, @bogdandrutu (and thanks @chris-smith-zocdoc for the contribution!). We'll take a look ASAP - at a glance, this looks great - but will confirm and let you know if there are any issues. |
Bumps [github.com/ory/go-acc](https://github.com/ory/go-acc) from 0.2.5 to 0.2.6. - [Release notes](https://github.com/ory/go-acc/releases) - [Commits](ory/go-acc@v0.2.5...v0.2.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
Update honeycomb exporter to use internal data format. The data produced by the exported now mirrors the open telemetry format more accurately.
This has several breaking changes to the events produced by the exporter. Please let me know if any of these are particularly problematic
New features
@MikeGoldsmith @paulosman