Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update honeycomb exporter to use internal data format #1689

Merged
merged 5 commits into from
Nov 25, 2020

Conversation

chris-smith-zocdoc
Copy link
Contributor

@chris-smith-zocdoc chris-smith-zocdoc commented Nov 24, 2020

Description:
Update honeycomb exporter to use internal data format. The data produced by the exported now mirrors the open telemetry format more accurately.

This has several breaking changes to the events produced by the exporter. Please let me know if any of these are particularly problematic

  • service_name -> service.name
  • process.hostname -> host.name
  • process.pid -> opencensus.pid (for census users)
  • opencensus.start_timestamp -> opencensus.starttime
  • has_remote_parent was removed
  • child_span_count was removed
  • source_format was removed
  • reftype from links was removed

New features

  • other span_kinds are now supported (consumer, producer, internal)

@MikeGoldsmith @paulosman

This has several breaking changes to the events produced by the exporter
- service_name -> service.name
- process.hostname -> host.name
- process.pid -> opencensus.pid (for census users)
- opencensus.start_timestamp -> opencensus.starttime
- has_remote_parent was removed
- source_format was removed

New features
- other span_kinds are now supported (consumer, producer, internal)
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1689 (bef1b7b) into master (aa2cdfa) will increase coverage by 0.06%.
The diff coverage is 89.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
+ Coverage   89.41%   89.47%   +0.06%     
==========================================
  Files         370      370              
  Lines       18141    18114      -27     
==========================================
- Hits        16221    16208      -13     
+ Misses       1430     1418      -12     
+ Partials      490      488       -2     
Flag Coverage Δ
integration 70.97% <ø> (ø)
unit 88.16% <89.81%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/honeycombexporter/factory.go 91.66% <75.00%> (-8.34%) ⬇️
exporter/honeycombexporter/honeycomb.go 88.63% <87.50%> (+8.63%) ⬆️
exporter/honeycombexporter/ids.go 100.00% <100.00%> (ø)
exporter/honeycombexporter/translator.go 100.00% <100.00%> (+13.11%) ⬆️
receiver/carbonreceiver/transport/tcp_server.go 66.00% <0.00%> (-1.00%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2cdfa...bef1b7b. Read the comment docs.

@bogdandrutu
Copy link
Member

Can you please fix the build?

@bogdandrutu bogdandrutu merged commit 03a7f07 into open-telemetry:master Nov 25, 2020
@bogdandrutu
Copy link
Member

@MikeGoldsmith @lizthegrey I may have made a mistake, I am not sure why you were not added as reviewer. If this is not ok for you please file a revert and I will immediately approve that. Sorry for this

@paulosman
Copy link
Member

Thanks, @bogdandrutu (and thanks @chris-smith-zocdoc for the contribution!). We'll take a look ASAP - at a glance, this looks great - but will confirm and let you know if there are any issues.

dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Bumps [github.com/ory/go-acc](https://github.com/ory/go-acc) from 0.2.5 to 0.2.6.
- [Release notes](https://github.com/ory/go-acc/releases)
- [Commits](ory/go-acc@v0.2.5...v0.2.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants