[aws-ecs-metrics-receiver] refactoring for better test coverage and error handling #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
hossain-rayhan
requested review from
anuraaga,
kbrockhoff and
a team
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 89.89% 89.90%
=======================================
Files 376 376
Lines 18147 18160 +13
=======================================
+ Hits 16314 16327 +13
Misses 1375 1375
Partials 458 458
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
anuraaga
reviewed
Dec 2, 2020
receiver/awsecscontainermetricsreceiver/awsecscontainermetrics/docker_stats.go
Show resolved
Hide resolved
anuraaga
approved these changes
Dec 2, 2020
bogdandrutu
approved these changes
Dec 2, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
This enchances proto file patching so that we can use gogo custom tags in proto files. The references to gogo.proto file is currently uses hard-coded version number in the path (github.com/gogo/protobuf@v1.3.1/gogoproto/gogo.proto). We will improve this in the future to automatically use the correct version number based on our go.mod file. This will be followed by a change which introduces a custom data type for trace_id field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change does some refactoring for better error handling and unit test coverage. We found a bug which was causing seg fault. To avoid such scenarios in future, we add some null checks and better unit tests.
Link to tracking Issue:
174
Testing:
More unit tests were added.
Manual e2e test.