Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-ecs-metrics-receiver] refactoring for better test coverage and error handling #1738

Merged
merged 3 commits into from
Dec 2, 2020
Merged

[aws-ecs-metrics-receiver] refactoring for better test coverage and error handling #1738

merged 3 commits into from
Dec 2, 2020

Commits on Dec 2, 2020

  1. add null check to avoid seg fault

    @hossain-rayhan
    hossain-rayhan committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    077484a View commit details
    Browse the repository at this point in the history

  2. check if memory and cpu limits are nil

    @hossain-rayhan
    hossain-rayhan committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a23d5f5 View commit details
    Browse the repository at this point in the history

  3. add unit tests for better coverage 

    Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
    @hossain-rayhan
    hossain-rayhan committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    c1aa100 View commit details
    Browse the repository at this point in the history