Add Log() to ottlfuncs #18200
Add Log() to ottlfuncs #18200
Conversation
mterhar
requested review from
a team,
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
|
|
There was a problem hiding this comment.
Improving how functions handle type assertion is a high priority right now in the ottl package and this PR will be affected by the outcome. I like this function and think there is value here, but I'd like to hold off for a moment while we finalize some other PRs to minimize the amount of rework and the size of those PRs.
Related discussion:
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 4 seconds (43 minutes 16 seconds less than
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
❌ changelog workflow has finished in 46 seconds (1 minute 58 seconds less than main branch avg.) and finished at 2nd Mar, 2023. 1 job failed.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | Ensure ./.chloggen/*.yaml addition(s) 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@mterhar we're ready for a merge/rebase. I can also take up this effort if you need to hand it off. |
|
When I hit "sync fork" in the github UI it killed the pull request so I made a new one. #21825 |
Addresses issue #18076
Description:
Adds a feature to allow OTTL expressions to get a logarithm of a value.
Link to tracking Issue: 18076
Testing: Tests were added in the same way the
Int()function is testedDocumentation: Added a readme section following the same pattern as
Int()which covers type for inputs and return values and examples.