[pkg/ottl] Add Log() to ottlfuncs #21825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mterhar
requested review from
a team,
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
TylerHelmuth
approved these changes
May 15, 2023
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
varunraiko
pushed a commit
to varunraiko/opentelemetry-collector-contrib
that referenced
this pull request
May 17, 2023
* Add Log() to ottlfuncs Addresses issue open-telemetry#18076 * redo the logarithm ottl with the new format * Handle negatives and zero as nil rather than NaN * replace lots of logic with FloatLikeGetter * Updated tests to work with FloatLikeGetter * Update readme with suggestion Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #18076
Description:
Adds a feature to allow OTTL expressions to get a logarithm of a value.
Link to tracking Issue: 18076
Testing: Tests were added in the same way the Int() function is tested
Documentation: Added a readme section following the same pattern as Int() which covers type for inputs and return values and examples.