sfxexporter: Add initial list of non-default metrics #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
force-pushed
the
sfxexporter-drop-non-default-metrics
branch
from
b1308c3
to
9dbb9fc
Compare
Always drop certain non-default metrics. A subsequent PR will be opened to add ability to override this behavior.
asuresh4
force-pushed
the
sfxexporter-drop-non-default-metrics
branch
from
9dbb9fc
to
c97a9f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.02%
==========================================
Files 396 396
Lines 19465 19484 +19
==========================================
+ Hits 17593 17608 +15
- Misses 1408 1410 +2
- Partials 464 466 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Jan 20, 2021
bogdandrutu
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Always drop certain non-default metrics. To begin with I've added a list of non-default host metrics. Will add remaining metrics in separate PRs. Also, I'll be opening a subsequent PR to add ability to override this default behavior to allow users to optionally send in these dropped metrics (done in #2146).
Testing: Added tests.