Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfxexporter: Add include metrics option #2146

Conversation

asuresh4
Copy link
Member

Depends on #2145

Description: Add include_metrics option. This option can be used to override the exclusion of metrics. This option can be used to included metrics that are otherwise dropped by default. For example, the following configuration can be used to send through some of that are dropped by default.

include_metrics
  # When sending in translated metrics.
  - metric_names: [cpu.interrupt, cpu.user, cpu.system]
  # When sending in metrics in OTel convention.
  - metric_name: system.cpu.time
    dimensions:
      state: [interrupt, user, system]

Testing: Updated/added tests.

Documentation: Updated README.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #2146 (3313d86) into master (6bf5f19) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
+ Coverage   90.37%   90.38%   +0.01%     
==========================================
  Files         397      397              
  Lines       19498    19509      +11     
==========================================
+ Hits        17621    17634      +13     
+ Misses       1411     1410       -1     
+ Partials      466      465       -1     
Flag Coverage Δ
integration 69.68% <ø> (ø)
unit 89.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/config.go 90.69% <ø> (ø)
exporter/signalfxexporter/exporter.go 97.26% <100.00%> (ø)
exporter/signalfxexporter/translation/converter.go 95.87% <100.00%> (+0.01%) ⬆️
...ignalfxexporter/translation/dpfilters/filterset.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf5f19...3313d86. Read the comment docs.

@asuresh4 asuresh4 force-pushed the sfxexporter-add-include-metrics-option branch from 2bc89fb to 8c85900 Compare January 20, 2021 03:03
exporter/signalfxexporter/README.md Outdated Show resolved Hide resolved
Collector automation moved this from In progress to Reviewer approved Jan 20, 2021
Add a "include_metrics" option. This option can be used to override metrics
that are excluded by default.
@asuresh4 asuresh4 force-pushed the sfxexporter-add-include-metrics-option branch from 8c85900 to 6a4b270 Compare January 20, 2021 18:01
Co-authored-by: Jay Camp <jay.r.camp@gmail.com>
@bogdandrutu bogdandrutu merged commit 9f137ea into open-telemetry:master Jan 20, 2021
Collector automation moved this from Reviewer approved to Done Jan 20, 2021
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md)
- [Commits](spf13/cobra@v1.0.0...v1.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Add internal pkg to bridge/opencensus

* Use the bridge/opencensus/internal pkg

* Correct testing comments

* Remove added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants