New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sfxexporter: Add include metrics option #2146
Merged
bogdandrutu
merged 2 commits into
open-telemetry:master
from
asuresh4:sfxexporter-add-include-metrics-option
Jan 20, 2021
Merged
sfxexporter: Add include metrics option #2146
bogdandrutu
merged 2 commits into
open-telemetry:master
from
asuresh4:sfxexporter-add-include-metrics-option
Jan 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2146 +/- ##
==========================================
+ Coverage 90.37% 90.38% +0.01%
==========================================
Files 397 397
Lines 19498 19509 +11
==========================================
+ Hits 17621 17634 +13
+ Misses 1411 1410 -1
+ Partials 466 465 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
sfxexporter-add-include-metrics-option
branch
from
January 20, 2021 03:03
2bc89fb
to
8c85900
Compare
jrcamp
approved these changes
Jan 20, 2021
Add a "include_metrics" option. This option can be used to override metrics that are excluded by default.
asuresh4
force-pushed
the
sfxexporter-add-include-metrics-option
branch
from
January 20, 2021 18:01
8c85900
to
6a4b270
Compare
Co-authored-by: Jay Camp <jay.r.camp@gmail.com>
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.0.0...v1.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add internal pkg to bridge/opencensus * Use the bridge/opencensus/internal pkg * Correct testing comments * Remove added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2145
Description: Add
include_metrics
option. This option can be used to override the exclusion of metrics. This option can be used to included metrics that are otherwise dropped by default. For example, the following configuration can be used to send through some of that are dropped by default.Testing: Updated/added tests.
Documentation: Updated README.