Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Add new FloatLikeGetter and FloatGetter #21896

Merged
merged 6 commits into from
May 12, 2023
Merged

[pkg/ottl] Add new FloatLikeGetter and FloatGetter #21896

merged 6 commits into from
May 12, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Adds new FloatLikeGetter and FloatGetter getters to facilitate float retrieval for functions who need floats.

Link to tracking Issue:
Related to #21825

Testing:
Added new tests

Documentation:
Added godoc strings

@github-actions github-actions bot requested a review from kentquirk May 12, 2023 15:30
@TylerHelmuth TylerHelmuth mentioned this pull request May 12, 2023
Merged
evan-bradley
evan-bradley reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. If you add these to the function parser, I think we're good to go.

@TylerHelmuth TylerHelmuth merged commit 0e43390 into open-telemetry:main May 12, 2023
85 checks passed
@TylerHelmuth TylerHelmuth deleted the ottl-floatlikegetter branch May 12, 2023 17:53
@github-actions github-actions bot added this to the next release milestone May 12, 2023
varunraiko pushed a commit to varunraiko/opentelemetry-collector-contrib that referenced this pull request May 17, 2023
@TylerHelmuth @varunraiko
[pkg/ottl] Add new FloatLikeGetter and FloatGetter (open-telemetry#21896
f5d5e9a 
)

* add new getters

* changelog

* Add support for converting bool

* Add to function parser

* Add to floatgetter tests

* Add to floatgetter slice support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@mx-psi mx-psi

Labels
pkg/ottl
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TylerHelmuth @evan-bradley @mx-psi