[processor/probabilisticsampler] use generated status header #22759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the component to generate the status table using mdatagen. Linked issue: open-telemetry#21213 Signed-off-by: Alex Boten <aboten@lightstep.com>
github-actions
bot
added
the
processor/probabilisticsampler
crobert-1
approved these changes
May 24, 2023
| stability: | ||
| beta: [traces] | ||
| alpha: [logs] | ||
| distributions: [core, contrib, observiq, splunk, sumo] |
There was a problem hiding this comment.
Should contrib be before core for alphabetical order, or do we specifically always want core and contrib as the first two entries before other distributions are listed? (I think it's best to have the primary distributions first before company-specific ones, just wanted to see if it's intentional or not).
Just looking for the best way to have consistency here.
There was a problem hiding this comment.
In other places we've always put core before contrib, i had the same question, but I'm not sure if it's important they be in alphabetical order 🤷🏻
There was a problem hiding this comment.
We generate the README according to a predefined order: core, contrib, then alphabetical.
mwear
approved these changes
May 24, 2023
atoulme
approved these changes
May 25, 2023
mx-psi
added
Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the component to generate the status table using mdatagen.
Linked issue: #21213