-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kusto Go SDK version , fixes issue #22771 #22933
Merged
dmitryax
merged 5 commits into
open-telemetry:main
from
ag-ramachandran:bugfix/FixRetriesAzureDataExplorer
Jun 2, 2023
Merged
Update Kusto Go SDK version , fixes issue #22771 #22933
dmitryax
merged 5 commits into
open-telemetry:main
from
ag-ramachandran:bugfix/FixRetriesAzureDataExplorer
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
Can you fix the merge conflicts? Thanks! |
G'day @mx-psi, merged and updated! |
dmitryax
reviewed
May 31, 2023
dmitryax
approved these changes
Jun 2, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…telemetry#22933) The underlying SDK has an update to fix an issue where the network connections are flaky. To get the metadata to connect to the service , a HTTP metadata call is issued. If this call fails , it is not retried and the init is interrupted till restart. The underlying SDK fixes it by reset of the lock that was causing this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
exporter/azuredataexplorer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The underlying SDK has an update to fix an issue where the network connections are flaky. To get the metadata to connect to the service , a HTTP metadata call is issued. If this call fails , it is not retried and the init is interrupted till restart. The underlying SDK fixes it by reset of the lock that was causing this behavior
Link to tracking Issue:
#22771
Testing:
--- PASS: Test_mapToAdxMetric (0.01s) --- PASS: Test_mapToAdxMetric/counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/int_counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/nil_counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/simple_histogram_with_value (0.00s) --- PASS: Test_mapToAdxMetric/nil_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/int_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/float_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/summary (0.00s) --- PASS: Test_mapToAdxMetric/nil_summary (0.00s) --- PASS: Test_mapToAdxMetric/unknown_type (0.00s) === RUN TestLoadConfig/azuredataexplorer/2 === RUN TestLoadConfig/azuredataexplorer/3 --- PASS: TestLoadConfig (0.02s) --- PASS: TestLoadConfig/azuredataexplorer (0.01s) --- PASS: TestLoadConfig/azuredataexplorer/2 (0.00s) --- PASS: TestLoadConfig/azuredataexplorer/3 (0.00s) --- PASS: TestCreateTracesExporterE2E (9.25s) --- PASS: TestCreateLogsExporterE2E (9.37s) --- PASS: TestCreateMetricsExporterE2E (10.36s) PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuredataexplorerexporter 31.642s
Documentation:
No changes