Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kusto Go SDK version , fixes issue #22771 #22933

Conversation

ag-ramachandran
Copy link
Contributor

Description:
The underlying SDK has an update to fix an issue where the network connections are flaky. To get the metadata to connect to the service , a HTTP metadata call is issued. If this call fails , it is not retried and the init is interrupted till restart. The underlying SDK fixes it by reset of the lock that was causing this behavior

Link to tracking Issue:
#22771

Testing:

  • Unit and E2E tests run
    --- PASS: Test_mapToAdxMetric (0.01s) --- PASS: Test_mapToAdxMetric/counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/int_counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/nil_counter_over_time (0.00s) --- PASS: Test_mapToAdxMetric/simple_histogram_with_value (0.00s) --- PASS: Test_mapToAdxMetric/nil_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/int_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/float_gauge_value (0.00s) --- PASS: Test_mapToAdxMetric/summary (0.00s) --- PASS: Test_mapToAdxMetric/nil_summary (0.00s) --- PASS: Test_mapToAdxMetric/unknown_type (0.00s) === RUN TestLoadConfig/azuredataexplorer/2 === RUN TestLoadConfig/azuredataexplorer/3 --- PASS: TestLoadConfig (0.02s) --- PASS: TestLoadConfig/azuredataexplorer (0.01s) --- PASS: TestLoadConfig/azuredataexplorer/2 (0.00s) --- PASS: TestLoadConfig/azuredataexplorer/3 (0.00s) --- PASS: TestCreateTracesExporterE2E (9.25s) --- PASS: TestCreateLogsExporterE2E (9.37s) --- PASS: TestCreateMetricsExporterE2E (10.36s) PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/azuredataexplorerexporter 31.642s

Documentation:
No changes

Copy link
Contributor

@ben-childs-docusign ben-childs-docusign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@mx-psi
Copy link
Member

mx-psi commented May 30, 2023

Can you fix the merge conflicts? Thanks!

@ag-ramachandran
Copy link
Contributor Author

Can you fix the merge conflicts? Thanks!

G'day @mx-psi, merged and updated!

@ag-ramachandran
Copy link
Contributor Author

Hello @dmitryax, @mx-psi if this looks okay, request your help for merge :)

@ag-ramachandran
Copy link
Contributor Author

Hello @mx-psi,@dmitryax. Sorry for 1 more message. When you get sometime could you please review/approve merge

@dmitryax dmitryax merged commit 4b5c264 into open-telemetry:main Jun 2, 2023
@github-actions github-actions bot added this to the next release milestone Jun 2, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…telemetry#22933)

The underlying SDK has an update to fix an issue where the network connections are flaky. To get the metadata to connect to the service , a HTTP metadata call is issued. If this call fails , it is not retried and the init is interrupted till restart. The underlying SDK fixes it by reset of the lock that was causing this behavior
@ag-ramachandran ag-ramachandran deleted the bugfix/FixRetriesAzureDataExplorer branch July 10, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants