Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadogexporter] Upgrade opentelemetry-mapping-go version and fix breaking changes #22952

Merged
merged 5 commits into from
May 30, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented May 30, 2023

Description:
Upgrade opentelemetry-mapping-go version and fix breaking changes

Link to tracking Issue:
Fixes #22917

Testing:

Documentation:

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 30, 2023
@songy23 songy23 requested review from a team and mx-psi as code owners May 30, 2023 16:07
@github-actions github-actions bot added the exporter/datadog Datadog components label May 30, 2023
@songy23 songy23 added the dependencies Pull requests that update a dependency file label May 30, 2023
@mx-psi
Copy link
Member

mx-psi commented May 30, 2023

Looks like you need to make gotidy?

@songy23 songy23 requested a review from dmitryax as a code owner May 30, 2023 16:22
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels May 30, 2023
@github-actions github-actions bot requested a review from pmcollins May 30, 2023 16:22
@songy23
Copy link
Member Author

songy23 commented May 30, 2023

@mx-psi good catch! Should have run it from the root. Should be fixed now

@mx-psi
Copy link
Member

mx-psi commented May 30, 2023

@mx-psi
Copy link
Member

mx-psi commented May 30, 2023

Needs make genotelcontribcol though :)

@songy23
Copy link
Member Author

songy23 commented May 30, 2023

build-and-test / integration-tests failed due to #18286.

@songy23 songy23 closed this May 30, 2023
@songy23 songy23 reopened this May 30, 2023
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting timed-out. restarted the failed jobs

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label May 30, 2023
@codeboten codeboten merged commit 84429d1 into open-telemetry:main May 30, 2023
@github-actions github-actions bot added this to the next release milestone May 30, 2023
@songy23 songy23 deleted the ddog-metrics branch May 30, 2023 20:31
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…nd fix breaking changes (open-telemetry#22952)

Upgrade opentelemetry-mapping-go version and fix breaking changes

Link to tracking Issue:
Fixes open-telemetry#22917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command dependencies Pull requests that update a dependency file exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/metrics from 0.2.1 to 0.2.3 causes issue
4 participants