[pkg/stanza] Rename tokenize package to split #26540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-rm-tokenize
branch
from
85956b8
to
ca85242
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-tokenize
branch
from
ca85242
to
c4de85e
Compare
dmitryax
previously approved these changes
Sep 11, 2023
dmitryax
dismissed
their stale review
Would like to see #26544 approved as well before merging this
dmitryax
approved these changes
Sep 11, 2023
djaglowski
added a commit
that referenced
this pull request
Sep 11, 2023
Subset of #26241 Follows #26540 - Rename `MultilineConfig` to `split.Config` - Remove `Multiline`, previously a struct representation that only wrapped a split func - Remove `NewMultilineConfig`, because `split.Config` is just two simple fields with "" defaults. - Condense references in tests - Substantially increate test coverage in `split` package.
|
Merged as part of #26544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another subset of #26241.
This renames the
tokenizepackage tosplit. Thetokenizepackage was created by isolating several related concerns into a single package. However, at this point, each of those concerns has been moved into a very specific package. e.g.decode,flush,trim,split.What remains of the tokenize package is only concerned with split functions, so the name is more appropriate going forward. Future PRs will rename some of the structs and functions in and relating to this package.