Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of the %z strptime format. #29929

Merged
merged 2 commits into from
Jan 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var ctimeSubstitutes = map[string]string{
"%f": "999999",
"%s": "99999999",
"%Z": "MST",
"%z": "-0700",
"%z": "Z0700",
"%w": "-070000",
"%i": "-07",
"%j": "-07:00",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,25 @@ func TestParse(t *testing.T) {
t.Errorf("Given: %v, expected: %v", dt, dt2)
}
}

func TestZulu(t *testing.T) {
format := "%Y-%m-%dT%H:%M:%S.%L%z"
// These time should all parse as UTC.
for _, input := range []string{
"2019-01-02T15:04:05.666666Z",
"2019-01-02T15:04:05.666666-0000",
"2019-01-02T15:04:05.666666+0000",
} {
t.Run(input, func(t *testing.T) {
dt, err := Parse(format, input)
if err != nil {
t.Error(err)
} else if dt.UnixNano() != dt1.UnixNano() {
// We compare the unix nanoseconds because Go has a subtle parsing difference between "Z" and "+0000".
// The former returns a Time with the UTC timezone, the latter returns a Time with a 0000 time zone offset.
// (See Go's documentation for `time.Parse`.)
t.Errorf("Given: %v, expected: %v", dt, dt1)
}
})
}
}
Loading