Nil check named pipe shutdowns #31088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `Start` method of the named pipe is called, it will create a new named pipe and start listening for connections. If that Start method _fails_ for any reason, some parts of the named pipe will not be initialized. This means that when the `Stop` method is called (as the collector does when `Start` fails), it will panic with a nil pointer dereference. This change adds a couple of nil checks to the `Stop` method to prevent this panic, because otherwise we just get the SIGSEGV signal, and we never get any error logs. Signed-off-by: sinkingpoint <colin@quirl.co.nz>
sinkingpoint
force-pushed
the
sinkingpoint/named-pipe-sigsev
branch
from
4fcb7f4
to
86827bc
Compare
djaglowski
approved these changes
Feb 6, 2024
djaglowski
added
the
ready to merge
codeboten
approved these changes
Feb 7, 2024
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
When the `Start` method of the named pipe is called, it will create a new named pipe and start listening for connections. If that Start method _fails_ for any reason, some parts of the named pipe will not be initialized. This means that when the `Stop` method is called (as the collector does when `Start` fails), it will panic with a nil pointer dereference. This change adds a couple of nil checks to the `Stop` method to prevent this panic, because otherwise we just get the SIGSEGV signal, and we never get any error logs. **Testing:** Running this in prod @ Cloudflare **Documentation:** <Describe the documentation added.> Signed-off-by: sinkingpoint <colin@quirl.co.nz>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the
Startmethod of the named pipe is called, it will create a new named pipe and start listening for connections. If that Start method fails for any reason, some parts of the named pipe will not be initialized. This means that when theStopmethod is called (as the collector does whenStartfails), it will panic with a nil pointer dereference.This change adds a couple of nil checks to the
Stopmethod to prevent this panic, because otherwise we just get the SIGSEGV signal, and we never get any error logs.Link to tracking Issue:
Testing: Running this in prod @ Cloudflare
Documentation: