Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil check named pipe shutdowns #31088

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Nil check named pipe shutdowns #31088

merged 1 commit into from
Feb 7, 2024

Commits on Feb 6, 2024

  1. Nil check named pipe shutdowns 

    When the `Start` method of the named pipe is called, it will create a
new named pipe and start listening for connections. If that
Start method _fails_ for any reason, some parts of the named pipe
will not be initialized. This means that when the `Stop` method is
called (as the collector does when `Start` fails), it will panic with a
nil pointer dereference.

This change adds a couple of nil checks to the `Stop` method
to prevent this panic, because otherwise we just get the SIGSEGV
signal, and we never get any error logs.

Signed-off-by: sinkingpoint <colin@quirl.co.nz>
    @sinkingpoint
    sinkingpoint committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    86827bc View commit details
    Browse the repository at this point in the history