[chore] Migrate the "generate" make target to mdatagen from core repo #31609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
djaglowski,
MovieStoreGuy,
andrzej-stencel,
dashpole,
atoulme,
jmacd,
codeboten,
fatsheep9146,
jpkrohling,
Aneurysm9,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
github-actions
bot
added
cmd/mdatagen
github-actions
bot
added
extension/remotetap
extension/sigv4auth
extension/solarwindsapmsettings
extension/storage
extension/sumologic
internal/tools
processor/attributes
dmitryax
force-pushed
the
migrate-mdatagen
branch
from
1d98d01
to
6ac33cf
Compare
github-actions
bot
added
processor/groupbytrace
|
failing tests should be fixed in #31610 |
dmitryax
force-pushed
the
migrate-mdatagen
branch
3 times, most recently
from
51c398b
to
4abe78d
Compare
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
dmitryax
force-pushed
the
migrate-mdatagen
branch
from
4abe78d
to
4640713
Compare
MovieStoreGuy
approved these changes
Mar 6, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates
generatemake target from using the deprecatedcmd/mdatagenin this repository to mdategen defined in core repository.To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and #21469 are resolved.
Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.:
awsproxyandjaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.This change unblocks #30495