New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the modules to use vanity url go.opentelemetry.io/collector-contrib #21469
Comments
@damemi had mentioned that the existing vanity URL redirect implementation is hosted by Google and needs to be transferred to OTel GC/TC or CNCF operation. I do not know the status or timelines of that effort. Beyond that, what would be the impact to users of these modules if we change the import path? What would the migration path look like? |
Yeah, I wrote up some details about how @MrAlias hit this in open-telemetry/opentelemetry-go-vanityurls#17, and the steps we took to finally publish it in this doc proposal. Now that the service account in the project has been given the necessary IAM roles, you should be able to deploy a new URL without needing a Googler to manually do anything with the project. But thinking longer term, it shouldn't be just Googlers with access to that project. I think @mtwo was planning to bring this up at the GC meeting. |
This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469 Signed-off-by: Alex Boten <aboten@lightstep.com>
An important question to me here is if this would mean a change for all ocb manifests (I expect the answer to be "yes") |
@mx-psi this sounds like something we could make the builder capable of managing for users to help alleviate the pain of the transition period. |
Fair enough, we can probably make the change transparent to users then, provided they are using a recent enough builder version. If we can, we potentially want to land the builder change before we do the migration itself, to minimize the number of "I am using an old builder" type of issues. I am okay with the migration if we do this 👍 |
@Aneurysm9 I believe it's only a one-time problem for the users that want to update the otel collector contrib dependencies in their repos. All the dependencies on the existing versions will continue working. We can mitigate the migration in the builder by renaming the modules under the hood, as @codeboten mentioned in #21382 (comment). For users that don't use the builder, maybe we can provide a shell command to replace import paths in their repos. Please let us know what other complications you can think of. |
This is to allow scope name to eventually use the vanity URL to identify the source of telemetry for components in that repository. Related issue: open-telemetry/opentelemetry-collector-contrib#21469 Signed-off-by: Alex Boten <aboten@lightstep.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
This change migrates `generate` make target from using deprecated cmd/mdatagen defined in this repo to mdategen defined in core repository. In order to avoid breaking changes for end users, we keep the scope names used in this repo the same as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolver. Taking the opportunity that that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: awsproxy and jaegerremotesampling. It's not a breaking change because the generated meter and tracer are not being used yet.
…#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and #21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks #30495
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
…open-telemetry#31609) This change migrates `generate` make target from using the deprecated `cmd/mdatagen` in this repository to mdategen defined in core repository. To avoid breaking changes for the end users, we keep the scope names used in this repo as before. This required defining them explicitly in metadata.yaml files. We can update them after open-telemetry/opentelemetry-collector#9494 and open-telemetry#21469 are resolved. Taking the opportunity that the scope names can be explicitly defined, this PR also updates missing scope names for extensions with inconsistent package names e.g.: `awsproxy` and `jaegerremotesampling`. It's not a breaking change because the generated meter and tracer are not being used yet. This change unblocks open-telemetry#30495
Similar to how it's done in the core repo, we should use vanity URLs for contrib modules:
github.com/open-telemetry/opentelemetry-collector-contrib -> go.opentelemetry.io/collector-contrib
Brought by @Aneurysm9 in #21272 (comment):
The text was updated successfully, but these errors were encountered: