[chore][CI/CD] Remove integration test naming restriction #32529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
dmitryax,
Frapschen,
hanjm and
SpencerTorres
github-actions
bot
added
exporter/dataset
exporter/splunkhec
receiver/cloudflare
labels
github-actions
bot
requested review from
atoulme,
dehaansa,
djaglowski,
martin-majlis-s1,
tomaz-s1 and
zdaratom-s1
TylerHelmuth
approved these changes
Apr 25, 2024
|
I've filed #32715 for the failing CI/CD action, it's unrelated to this PR. |
crobert-1
added
the
ready to merge
|
Added |
djaglowski
pushed a commit
that referenced
this pull request
Apr 30, 2024
…32717) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This fixes 2/3 failing integration tests in #32543. The last failing test `TestAlertsReceiverTLS` needs to be skipped for now, as its cert files are invalid and need to be re-generated. All three of these tests are currently being skipped, but will run again when #32529 is merged. **Link to tracking Issue:** <Issue number if applicable> #32529 #32543 **Testing:** <Describe what testing was performed and which tests were added.> Two tests are passing again locally.
codeboten
reviewed
May 1, 2024
Co-authored-by: Antoine Toulme <antoine@toulme.name>
crobert-1
commented
May 1, 2024
crobert-1
commented
May 1, 2024
|
I've resolved the conflict and updated other tests based on more merged PRs. This should be ready (pending passing CI/CD). |
atoulme
approved these changes
May 1, 2024
codeboten
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Including the
-run=Integrationargument in themakecommand means that only integration tests that includeIntegrationin their name will be run. This requirement is not obvious to users, so there are currently around 15 integration tests that aren't being run because they don't conform to this requirement. I think the best approach here is to remove the-runargument (rather than rename tests) so that this doesn't happen again.Link to tracking Issue:
Resolves #32207