[extension/ecsobserver] Add docker label based matcher #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingleig
force-pushed
the
ecssd-matcher-docker
branch
from
38e93ad
to
0d9d759
Compare
pingleig
changed the title
pingleig
force-pushed
the
ecssd-matcher-docker
branch
from
0d9d759
to
e8413b7
Compare
mxiamxia
reviewed
May 3, 2021
pingleig
force-pushed
the
ecssd-matcher-docker
branch
3 times, most recently
from
9e70efc
to
6df9ea8
Compare
Aneurysm9
reviewed
May 5, 2021
pingleig
force-pushed
the
ecssd-matcher-docker
branch
from
6df9ea8
to
af89540
Compare
Aneurysm9
approved these changes
May 5, 2021
|
Please rebase and fix conflicts :) |
pingleig
force-pushed
the
ecssd-matcher-docker
branch
2 times, most recently
from
f55dde7
to
a6b77ea
Compare
|
@bogdandrutu Fixed the conflict. |
|
ping @bogdandrutu |
Split from open-telemetry#2734 - Get port number from label value - Check if the port number exists in container definition
pingleig
force-pushed
the
ecssd-matcher-docker
branch
from
a6b77ea
to
891ff2d
Compare
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
… extensions configuration map (#3340) This PR is a port of the configfrpc's ToDialOptions() and confighttp ToClient() from PR #3128 in a piece meal fashion. The following are the changes - Refactored configgrpc.PerRPCAuth as extension implementing configauth.GrpcClientAuthenticator - Plugged in extensions configuration to all the grpc based clients in the core (OTLP, OpenCensus, Jaeger, JaegerReceiver) - Plugged in extensions configuration to all the HTTP based clients in the core (Zipkin, OTLPHTTP) Link to tracking Issue: #3282 #3276 Testing: Unit tests, [manual test described (for only oidc)](#3128 (comment))
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
Split from open-telemetry#2734 - Get port number from label value - Check if the port number exists in container definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implements docker label based matching for Prometheus ECS discovery extension i.e. ecsobserver.
Split from #2734
Link to tracking Issue:
Pending PRs
Previous PRs
Testing:
unit test
Documentation:
No new doc. See existing doc