[extension/ecsobserver] Add exporter to convert task to target #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed because of cert error in some other packages |
pingleig
changed the title
anuraaga
reviewed
May 6, 2021
pingleig
force-pushed
the
ecssd-exporter
branch
6 times, most recently
from
368ba5b
to
188f98c
Compare
|
ping @anuraaga |
anuraaga
reviewed
May 14, 2021
|
@jrcamp please review. |
jrcamp
reviewed
May 21, 2021
anuraaga
approved these changes
May 25, 2021
|
Please rebase |
This allow searching for log based on field value.
This should aovid use defining getter and setters
Its shadow warning seems to be a bit buggy
sum file is updated, might caused by merging
|
@bogdandrutu rebased, thx! |
Aneurysm9
approved these changes
Jun 2, 2021
alolita
added
the
ready to merge
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…telemetry#3333) * ext: ecsobserver Add exporter to convert task to target * ext: ecsobserver Don't export TaskExporter * ext: ecsobserver Add printing typed error to log fields This allow searching for log based on field value. * ext: ecsobserver Add errctx package This should aovid use defining getter and setters * ext: ecssd Use errctx and remove getter and setter * ext: ecssd Fix linter errors Its shadow warning seems to be a bit buggy * ext: ecsobserver Run go mod tidy sum file is updated, might caused by merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Export discovered ECS task as Prometheus scrape targets.
Link to tracking Issue:
Pending PRs
Previous PRs
Testing:
unit test
Documentation:
No new doc. See existing doc