[exporter/datadog] Always use http for logs agent exporter #33504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Jun 12, 2024
|
Does this fix #33195 ? If so, can you add 'Fixes' before the issue number so that the issue gets automatically closed when merging this? |
songy23
approved these changes
Jun 12, 2024
|
e2e test failures are unrelated: #33512 |
songy23
added
the
ready to merge
t00mas
pushed a commit
to t00mas/opentelemetry-collector-contrib
that referenced
this pull request
Jun 18, 2024
…metry#33504) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add default config option to always use http for logs agent exporter. Fixes bug where logs agent exporter was falling back to using tcp, causing collector shut down. Also opened a PR in datadog-agent for adding a warn log when the logs agent connectivity check fails: DataDog/datadog-agent#26626 **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#33195 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add default config option to always use http for logs agent exporter. Fixes bug where logs agent exporter was falling back to using tcp, causing collector shut down.
Also opened a PR in datadog-agent for adding a warn log when the logs agent connectivity check fails: DataDog/datadog-agent#26626
Link to tracking Issue:
Fixes #33195
Testing:
Documentation: