Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warn log for OTel logs agent connectivity check #26626

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Adds a warn log when the connectivity check fails for the OTel logs agent. This will appear as the following in the collector:

2024-06-11T16:22:28.831-0400    warn    clientutil/api.go:48    Error while validating API key  {"kind": "exporter", "data_type": "metrics", "name": "datadog/api", "error": "403 Forbidden"}
2024-06-11T16:22:28.831-0400    warn    clientutil/api.go:48    Error while validating API key  {"kind": "exporter", "data_type": "traces", "name": "datadog/api", "error": "403 Forbidden"}
2024-06-11T16:22:28.831-0400    warn    datadogexporter@v0.102.0/zaplogger.go:43        Error while validating API key        {"kind": "exporter", "data_type": "logs", "name": "datadog/api"}

Motivation

With this change, we plan to use logs_config.force_use_http in the logs agent default config which should solve this upstream issue: open-telemetry/opentelemetry-collector-contrib#33195

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=36460065 --os-family=ubuntu

Note: This applies to commit 0e6e9a5

@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2024

Regression Detector

Regression Detector Results

Run ID: f3261861-f082-4f5c-a214-62aee08048e4
Baseline: 295c0b8
Comparison: 0e6e9a5

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +3.65 [-17.68, +24.98]
file_tree memory utilization +0.91 [+0.81, +1.00]
basic_py_check % cpu utilization +0.28 [-2.59, +3.16]
idle memory utilization +0.24 [+0.20, +0.28]
uds_dogstatsd_to_api ingress throughput +0.02 [-0.19, +0.22]
trace_agent_msgpack ingress throughput +0.01 [+0.01, +0.02]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.05, +0.01]
otel_to_otel_logs ingress throughput -0.15 [-0.53, +0.22]
pycheck_1000_100byte_tags % cpu utilization -0.52 [-5.37, +4.32]
uds_dogstatsd_to_api_cpu % cpu utilization -1.69 [-4.69, +1.32]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liustanley
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 34m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 35fe6f1 into main Jun 12, 2024
217 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stanley.liu/logs-agent-error branch June 12, 2024 17:12
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jun 12, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Add default config option to always use http for logs agent exporter.
Fixes bug where logs agent exporter was falling back to using tcp,
causing collector shut down.

Also opened a PR in datadog-agent for adding a warn log when the logs
agent connectivity check fails:
DataDog/datadog-agent#26626

**Link to tracking Issue:** <Issue number if applicable>
Fixes
#33195

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
t00mas pushed a commit to t00mas/opentelemetry-collector-contrib that referenced this pull request Jun 18, 2024
…metry#33504)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Add default config option to always use http for logs agent exporter.
Fixes bug where logs agent exporter was falling back to using tcp,
causing collector shut down.

Also opened a PR in datadog-agent for adding a warn log when the logs
agent connectivity check fails:
DataDog/datadog-agent#26626

**Link to tracking Issue:** <Issue number if applicable>
Fixes
open-telemetry#33195

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants