[receiver/mongodb] Add mongodb host resource attributes #33714
Conversation
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement |
There was a problem hiding this comment.
Out of ignorance: It's considered a breaking change when metrics are switched to be enabled by default. Since we're adding a resource attribute that is now enabled by default, should this also be a breaking change? Or is it so little extra data that it doesn't merit the breaking label?
I guess counterpoint, adding attributes to metrics isn't considered a breaking change, so I'm not sure where the line in the sand is. (I'm also not finding documentation on this, either way).
There was a problem hiding this comment.
We don't have strict guidelines for the resource attributes. I'd say adding a new resource attribute is not a breaking change because it doesn't change cardinality. Removing or changing one should be considered a breaking change, though.
Happy to hear other opinions. cc @djaglowski
There was a problem hiding this comment.
I've generally considered it a breaking change because it breaks time series that are based on all attributes.
There was a problem hiding this comment.
By breaking time series you mean just the interrupted continuity, no other user-facing effect, right?
There was a problem hiding this comment.
I would merge this as is, assuming that's the case ^. Let me know if there are any other consequences for the end user that I miss, I'll change it.
|
Looks like the integration expected test data needs to be updated to include the new resource attribute. |
dmitryax
force-pushed
the
mongodb-add-address-resource-attr
branch
from
dc2592e
to
1dbbde5
Compare
The new attribute are added to the MongoDB receiver to distinguish metrics coming from different MongoDB instances. - `server.address`: The address of the MongoDB host, enabled by default. - `server.port`: The port of the MongoDB host, disabled by default. Co-authored-by: Curtis Robert <crobert@splunk.com>
dmitryax
force-pushed
the
mongodb-add-address-resource-attr
branch
from
1dbbde5
to
9be660c
Compare
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement |
There was a problem hiding this comment.
I've generally considered it a breaking change because it breaks time series that are based on all attributes.
The new attribute are added to the MongoDB receiver to distinguish metrics coming from different MongoDB instances.
server.address: The address of the MongoDB host, enabled by default.server.port: The port of the MongoDB host, disabled by default.Resolves #32350 and #32810