Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Enable goleak oidcauthextension #35282

Merged

Conversation

iblancasa
Copy link
Contributor

Related to #30438

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need a rebase

extension/oidcauthextension/metadata.yaml Outdated Show resolved Hide resolved
@iblancasa
Copy link
Contributor Author

Can somebody from @collector-contrib-approvers take a look?

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth adding a changelog here: This is fixing a bug in the extension, so we can let users know that we're fixing a memory leak here.

pkg/kafka/topic/go.mod Outdated Show resolved Hide resolved
extension/oidcauthextension/extension.go Outdated Show resolved Hide resolved
…ting down

Signed-off-by: Israel Blancas <iblancas@redhat.com>
.chloggen/enable-goleak-oidcauthextension.yaml Outdated Show resolved Hide resolved
.chloggen/enable-goleak-oidcauthextension.yaml Outdated Show resolved Hide resolved
iblancasa and others added 8 commits October 4, 2024 23:29
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
…a/opentelemetry-collector-contrib into enable-goleak-oidcauthextension
…tor-contrib into enable-goleak-oidcauthextension
…a/opentelemetry-collector-contrib into enable-goleak-oidcauthextension
…tor-contrib into enable-goleak-oidcauthextension
@MovieStoreGuy MovieStoreGuy merged commit aa89dc7 into open-telemetry:main Oct 9, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants