Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export spans to hec #359

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Export spans to hec #359

merged 5 commits into from
Jun 30, 2020

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jun 24, 2020

Description:
Adds trace exports support to Splunk HEC.

Testing:
Unit tests.

Documentation:
No doc - this is complementary to the metric export support with no additional config keys.

@atoulme atoulme requested a review from a team as a code owner June 24, 2020 19:15
@project-bot project-bot bot added this to In progress in Collector Jun 24, 2020
@atoulme
Copy link
Contributor Author

atoulme commented Jun 24, 2020

Opened after closing #323 to trigger coverage.

@rmfitzpatrick rmfitzpatrick mentioned this pull request Jun 24, 2020
Closed
@rmfitzpatrick
Copy link
Contributor

@atoulme, thanks for your patience. Would you mind rebasing to generate new hashes? I believe that will engage codecov (tested in #360).

@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #359 into master will increase coverage by 0.07%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   83.49%   83.56%   +0.07%     
==========================================
  Files         171      172       +1     
  Lines        9262     9339      +77     
==========================================
+ Hits         7733     7804      +71     
- Misses       1199     1202       +3     
- Partials      330      333       +3
Flag Coverage Δ
#integration 63.40% <ø> (ø)
#unit 83.34% <95.12%> (+0.07%) ⬆️
Impacted Files Coverage Δ
exporter/splunkhecexporter/client.go 84.78% <89.74%> (-0.13%) ⬇️
exporter/splunkhecexporter/exporter.go 96.15% <100.00%> (+0.50%) ⬆️
exporter/splunkhecexporter/factory.go 100.00% <100.00%> (ø)
exporter/splunkhecexporter/metricdata_to_splunk.go 74.48% <100.00%> (ø)
exporter/splunkhecexporter/tracedata_to_splunk.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d351dec...c447bc7. Read the comment docs.

@tigrannajaryan tigrannajaryan self-assigned this Jun 29, 2020
tigrannajaryan
tigrannajaryan approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Collector automation moved this from In progress to Reviewer approved Jun 30, 2020
@tigrannajaryan tigrannajaryan merged commit 625973a into open-telemetry:master Jun 30, 2020
Collector automation moved this from Reviewer approved to Done Jun 30, 2020
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector-contrib that referenced this pull request Jun 30, 2020
Revert "Export spans to hec (open-telemetry#359)"
988c760 
This reverts commit 625973a.

Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.
tigrannajaryan added a commit that referenced this pull request Jun 30, 2020
@tigrannajaryan
Revert "Export spans to hec (#359)" (#375)
891b1bc 
This reverts commit 625973a.

Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.
atoulme added a commit to atoulme/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2020
@atoulme
Revert "Revert "Export spans to hec (open-telemetry#359)" (open-telem…
7ba97f6 
…etry#375)"

This reverts commit 891b1bc.
@atoulme atoulme mentioned this pull request Jul 6, 2020
Merged
tigrannajaryan pushed a commit that referenced this pull request Jul 6, 2020
@atoulme
Unrevert span export to hec (#399)
b4ad0a4 
* Revert "Revert "Export spans to hec (#359)" (#375)"

This reverts commit 891b1bc.

This unreverts the revert of #359, now that the release is out.
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@atoulme @wyTrivail
Export spans to hec (#359)
1571375 
Adds trace exports support to Splunk HEC.

Testing:
Unit tests.

Documentation:
No doc - this is complementary to the metric export support with no additional config keys.
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@tigrannajaryan @wyTrivail
Revert "Export spans to hec (#359)" (#375)
4f02929 
This reverts commit 625973a.

Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@atoulme @wyTrivail
Unrevert span export to hec (#399)
65b656a 
* Revert "Revert "Export spans to hec (#359)" (#375)"

This reverts commit 891b1bc.

This unreverts the revert of #359, now that the release is out.
@atoulme atoulme mentioned this pull request Sep 18, 2020
Closed
6 tasks
pmalek-sumo referenced this pull request in pmalek-sumo/opentelemetry-collector-contrib Feb 18, 2021
@pmm-sumo
Introduce cascading filter processor (#359)
fa54d6f 
* Introduce cascading filter processor
pmalek-sumo referenced this pull request in pmalek-sumo/opentelemetry-collector-contrib Apr 13, 2021
@pmm-sumo @pmalek
Introduce cascading filter processor (#359)
a17cd00 
* Introduce cascading filter processor
sumo-drosiek referenced this pull request in sumo-drosiek/opentelemetry-collector-contrib Apr 22, 2021
@pmm-sumo @pmalek
Introduce cascading filter processor (#359)
a7e8f00 
* Introduce cascading filter processor
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@ferhatelmas @rghetia
Drop GO111MODULE environment variable (#359)
921ea03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atoulme @rmfitzpatrick @tigrannajaryan