Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrevert span export to hec #399

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Unrevert span export to hec #399

merged 3 commits into from
Jul 6, 2020

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 6, 2020

Description:
This unreverts the revert of #359, now that the release is out.

@atoulme atoulme requested a review from a team July 6, 2020 17:07
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #399 into master will increase coverage by 0.06%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   84.01%   84.08%   +0.06%     
==========================================
  Files         180      181       +1     
  Lines        9603     9680      +77     
==========================================
+ Hits         8068     8139      +71     
- Misses       1205     1208       +3     
- Partials      330      333       +3
Flag Coverage Δ
#integration 63.22% <ø> (ø)
#unit 83.87% <95.12%> (+0.06%) ⬆️
Impacted Files Coverage Δ
exporter/splunkhecexporter/client.go 84.78% <89.74%> (-0.13%) ⬇️
exporter/splunkhecexporter/exporter.go 96.15% <100.00%> (+0.50%) ⬆️
exporter/splunkhecexporter/factory.go 100.00% <100.00%> (ø)
exporter/splunkhecexporter/metricdata_to_splunk.go 74.48% <100.00%> (ø)
exporter/splunkhecexporter/tracedata_to_splunk.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46122f9...24ec8cd. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit b4ad0a4 into open-telemetry:master Jul 6, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@atoulme @wyTrivail
Unrevert span export to hec (#399)
65b656a 
* Revert "Revert "Export spans to hec (#359)" (#375)"

This reverts commit 891b1bc.

This unreverts the revert of #359, now that the release is out.
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
@flands
Move probablistic and tail sampling processors under common parent (#399
e7f231e 
)

* Move probablistic and tail sampling processors under common parent

Phase 1 change to defining sampling processors. This structure follows
what is done in the receiver and exporter folders.

* Import from proper directory for sampling
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@jmacd @rghetia
Comments in the metrics SDK (#399)
11f67ce 
* Comments from walkthrough

* Update
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@owais
Account for ProxyTracerProvider (#399)
ca8eac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atoulme @tigrannajaryan @rmfitzpatrick