Correctly obtain machine-type info from gce metadata #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 83.92% 83.90% -0.03%
==========================================
Files 178 178
Lines 9520 9520
==========================================
- Hits 7990 7988 -2
- Misses 1202 1203 +1
- Partials 328 329 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 9, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Split out metric test utils from metrics_adjuster_test and move to testutils * Reorder import of metrics testutils in metrics_adjuster_test * Move new metrics test utils to their own package * Rename some utility functions for clarity
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Introduce simplified export pipeline setup for stdout * Standardize dogstatsd,stdout,prometheus calling. * Creates NewRawExporter, NewExportPipeline, InstallNewPipeline methods. * Uses Options rather than Config throughout for options. * fix merge conflicts. Co-authored-by: Liz Fong-Jones <elizabeth@ctyalcove.org>
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
These two packages are closely related. They were separate for historical reasons but should be brought together to simplify the codebase.
codeboten
added a commit
that referenced
this pull request
Nov 23, 2022
This change implements the Context API portion of OTEP #66. The CorrelationContext API and Propagation API changes will come in future PRs. We're leveraging entrypoints to support other implementations of the Context API if/when necessary. For backwards compatibility, this change uses aiocontextvars for Python versions older than 3.7. Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com> Co-authored-by: Mauricio Vásquez <mauricio@kinvolk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on GCE instance & validated this works as expected