kubeletstatsreceiver: Sync available volume metadata from /pods endpoint #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 86.13% 86.20% +0.06%
==========================================
Files 207 207
Lines 11317 11365 +48
==========================================
+ Hits 9748 9797 +49
- Misses 1238 1239 +1
+ Partials 331 329 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
kubelet-volumes-2
branch
from
988ba7c
to
e618ad7
Compare
dmitryax
reviewed
Aug 14, 2020
dmitryax
reviewed
Aug 14, 2020
| ) | ||
|
|
||
| var supportedLabels = map[MetadataLabel]bool{ | ||
| MetadataLabelContainerID: true, | ||
| labelVolumeType: true, |
There was a problem hiding this comment.
shouldn't it be MetadataLabelVolumeType?
dmitryax
reviewed
Aug 14, 2020
|
@bogdandrutu - this is ready to merge. Please do when you get a chance. |
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Increase instance size for prior-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Optionally sync
k8s.volume.typelabel with volume metric. This information is collected from the Pod spec exposed via/podsendpoint only if the receiver is configured to do so (usingextra_metadata_labelsoption).Currently, Persistent Volume Claim is synced as its own type. This will be updated in a subsequent PR so that metadata from the actual storage backing the claim is synced instead using the Kubernetes API.
Testing: Added tests.
Documentation: Updated README.