Update carbon and wavefront to the new interface #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
carbonwave
branch
2 times, most recently
from
dcc7254
to
a0347c1
Compare
dmitryax
approved these changes
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 87.20% 87.22% +0.01%
==========================================
Files 210 210
Lines 11387 11387
==========================================
+ Hits 9930 9932 +2
+ Misses 1116 1114 -2
Partials 341 341
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
carbonwave
branch
from
a0347c1
to
349f3c1
Compare
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
This makes testing the collector locally harder. Also the condition is not enforced because having a disabled processor in the pipeline passes that condition which makes it not very useful.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Fixes #744 This is a temporary hotfix for the issue linked above. We'll need to figure out a proper fix later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.