k8sprocessor: wrap metrics before sending further down the pipeline #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapping was missed in k8sprocessor processor so any new-style component down the pipeline would drop all the k8s tags from the metrics.
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
===========================================
+ Coverage 72.00% 88.14% +16.14%
===========================================
Files 14 231 +217
Lines 600 12408 +11808
===========================================
+ Hits 432 10937 +10505
- Misses 144 1116 +972
- Partials 24 355 +331
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
owais
approved these changes
Aug 27, 2020
bogdandrutu
approved these changes
Aug 27, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
…ces (#837) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…/jaeger (#837) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: evantorrie <evantorrie@users.noreply.github.com> Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
* feat: support older pika versions * update tox.ini * update changelog * take version from pika * avoid exception when property name changes * add callback attr name test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The wrapping was missed in k8sprocessor, so any new-style component down the pipeline would drop all the k8s tags added to metrics.