Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/prometheus] Support OpenMetrics Info and Stateset metrics #9378

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

dashpole
Copy link
Contributor

Description:
Fixes #8516 by converting OpenMetrics info and stateset metrics to non-monotonic sums, as described in the specification.

Testing:

Unit tests added.

@dashpole dashpole requested review from a team and Aneurysm9 as code owners April 20, 2022 16:35
@dashpole dashpole force-pushed the info_stateset branch 3 times, most recently from c50cdfb to 0964420 Compare April 25, 2022 12:52
@dashpole
Copy link
Contributor Author

cc @open-telemetry/wg-prometheus

@dashpole dashpole added the comp:prometheus Prometheus related issues label Apr 25, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 21, 2022
@dashpole dashpole removed the Stale label May 24, 2022
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Jun 6, 2022
@codeboten codeboten merged commit 93786a4 into open-telemetry:main Jun 7, 2022
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…pen-telemetry#9378)

* [receiver/prometheus] support OpenMetrics Info and Stateset metrics

* Update CHANGELOG.md

* Update receiver/prometheusreceiver/internal/otlp_metricsbuilder.go

Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:prometheus Prometheus related issues ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheusreceiver] Convert Info and StateSet metrics to non-monotonic sums
4 participants