SFx exporter: add cpu delta translations #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
===========================================
+ Coverage 74.88% 88.66% +13.77%
===========================================
Files 21 245 +224
Lines 1071 13187 +12116
===========================================
+ Hits 802 11692 +10890
- Misses 213 1139 +926
- Partials 56 356 +300
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pmcollins
changed the title
dmitryax
reviewed
Sep 9, 2020
dmitryax
reviewed
Sep 9, 2020
Done. |
dmitryax
reviewed
Sep 10, 2020
dmitryax
approved these changes
Sep 10, 2020
Merged
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Fixes open-telemetry/opentelemetry-collector#954 #954 is being caused from the conversion of OC -> Internal -> OC span types. OC technically allows nil times because its a pointer, but [docs state](https://github.com/census-instrumentation/opencensus-proto/blob/master/src/opencensus/proto/trace/v1/trace.proto#L125-L135) ```go // This field is semantically required. When not set on receive - // receiver should set it to the value of end_time field if it was // set. Or to the current time if neither was set. It is important to // keep end_time > start_time for consistency. // // This field is required. StartTime *timestamp.Timestamp ``` So this pr changes the zipkin receiver to set the start/end timestamps if they're not set on receive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.