-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFx exporter: add cpu delta translations #954
SFx exporter: add cpu delta translations #954
Conversation
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
===========================================
+ Coverage 74.88% 88.66% +13.77%
===========================================
Files 21 245 +224
Lines 1071 13187 +12116
===========================================
+ Hits 802 11692 +10890
- Misses 213 1139 +926
- Partials 56 356 +300
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove k8s.node.cpu.utilization: cpu.utilization
mapping from translations
Done. |
Fixes open-telemetry/opentelemetry-collector#954 #954 is being caused from the conversion of OC -> Internal -> OC span types. OC technically allows nil times because its a pointer, but [docs state](https://github.com/census-instrumentation/opencensus-proto/blob/master/src/opencensus/proto/trace/v1/trace.proto#L125-L135) ```go // This field is semantically required. When not set on receive - // receiver should set it to the value of end_time field if it was // set. Or to the current time if neither was set. It is important to // keep end_time > start_time for consistency. // // This field is required. StartTime *timestamp.Timestamp ``` So this pr changes the zipkin receiver to set the start/end timestamps if they're not set on receive
No description provided.