-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource Detection Processor: Logs Support #970
Resource Detection Processor: Logs Support #970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 88.47% 88.50% +0.02%
==========================================
Files 245 245
Lines 13089 13103 +14
==========================================
+ Hits 11581 11597 +16
+ Misses 1148 1147 -1
+ Partials 360 359 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Seems this triggered the original build, removing the duplicate PR |
Finally looks like it works :) |
* Remove IndexedAttribute from api/label IndexedAttribute is a synonym for IndexedLabel and a hold over from when this iterator pattern had multiple implementations. Given it no longer is uses, remove it to avoid introducing confusion to users. * Update Changelog * Update Changelog PR number
Description:
Add logs support to
resourcedetection
processorThis is a re-open of #967 due to issues with triggering CircleCI build
Link to tracking Issue: open-telemetry/opentelemetry-collector#1653
Testing: unit test for logs added. Tested manually with EC2 and ENV detectors
Documentation: Added a note on logs being supported by the processor