Resource Detection Processor: Logs Support #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
==========================================
+ Coverage 88.47% 88.50% +0.02%
==========================================
Files 245 245
Lines 13089 13103 +14
==========================================
+ Hits 11581 11597 +16
+ Misses 1148 1147 -1
+ Partials 360 359 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Seems this triggered the original build, removing the duplicate PR |
pmm-sumo
changed the title
|
Finally looks like it works :) |
bogdandrutu
approved these changes
Sep 8, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Remove IndexedAttribute from api/label IndexedAttribute is a synonym for IndexedLabel and a hold over from when this iterator pattern had multiple implementations. Given it no longer is uses, remove it to avoid introducing confusion to users. * Update Changelog * Update Changelog PR number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add logs support to
resourcedetectionprocessorThis is a re-open of #967 due to issues with triggering CircleCI build
Link to tracking Issue: open-telemetry/opentelemetry-collector#1653
Testing: unit test for logs added. Tested manually with EC2 and ENV detectors
Documentation: Added a note on logs being supported by the processor