-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http_forwarder skeleton #979
Add http_forwarder skeleton #979
Conversation
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 88.77% 88.78% +0.01%
==========================================
Files 247 249 +2
Lines 13272 13295 +23
==========================================
+ Hits 11782 11804 +22
- Misses 1135 1139 +4
+ Partials 355 352 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
PTAL @jrcamp @bogdandrutu |
e56d1f0
to
1a41aa9
Compare
f84fcec
to
405a0c4
Compare
bcab66b
to
8ed785d
Compare
Note: All of the cudos go to @dneray for the logic/testing/effort in open-telemetry/opentelemetry-collector#981 This pr is based off of it with the following modifications - The config looks like ``` - key : <key to use for applying the rule too> pattern: <the regex pattern with named submatchers> action: extract ``` I think that the original PR is going in the right way for what we can the internal logic to be but as the issue #979 and #1170 indicate we need to take a step back and redesign the attributes processor (or make it clear of its limitations). This pr unblocks the required functionality. **Link to tracking Issue:** #979 **Link to follow up issue:** #1170 **Testing:** Added tests for extracting. **Documentation:** Updated processor readme.
http.ResponseWriters may implement additional interfaces (http.CloseNotifier, http.Flusher, http.Hijacker, http.Pusher, io.ReaderFrom) that get lost when the ResponseWriter is wrapped in another object. This change uses the httpsnoop package to wrap the ResponseWriter so that the resulting object implements any of the optional interfaces that the original ResponseWriter implements as well as using the replacement ResponseWriter methods that gather information for tracing.
Description: Add skeleton for
http_forwarder
extension that forwards HTTP requests to a specified target.Testing: Tests added.
Documentation: README added.