Add http_forwarder skeleton #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 88.77% 88.78% +0.01%
==========================================
Files 247 249 +2
Lines 13272 13295 +23
==========================================
+ Hits 11782 11804 +22
- Misses 1135 1139 +4
+ Partials 355 352 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
PTAL @jrcamp @bogdandrutu |
asuresh4
force-pushed
the
http-forwarder-extension
branch
from
e56d1f0
to
1a41aa9
Compare
bogdandrutu
reviewed
Sep 10, 2020
asuresh4
force-pushed
the
http-forwarder-extension
branch
from
f84fcec
to
405a0c4
Compare
bogdandrutu
approved these changes
Sep 11, 2020
asuresh4
force-pushed
the
http-forwarder-extension
branch
from
bcab66b
to
8ed785d
Compare
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Note: All of the cudos go to @dneray for the logic/testing/effort in open-telemetry/opentelemetry-collector#981 This pr is based off of it with the following modifications - The config looks like ``` - key : <key to use for applying the rule too> pattern: <the regex pattern with named submatchers> action: extract ``` I think that the original PR is going in the right way for what we can the internal logic to be but as the issue #979 and #1170 indicate we need to take a step back and redesign the attributes processor (or make it clear of its limitations). This pr unblocks the required functionality. **Link to tracking Issue:** #979 **Link to follow up issue:** #1170 **Testing:** Added tests for extracting. **Documentation:** Updated processor readme.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
http.ResponseWriters may implement additional interfaces (http.CloseNotifier, http.Flusher, http.Hijacker, http.Pusher, io.ReaderFrom) that get lost when the ResponseWriter is wrapped in another object. This change uses the httpsnoop package to wrap the ResponseWriter so that the resulting object implements any of the optional interfaces that the original ResponseWriter implements as well as using the replacement ResponseWriter methods that gather information for tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add skeleton for
http_forwarderextension that forwards HTTP requests to a specified target.Testing: Tests added.
Documentation: README added.