-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows zip #375
base: main
Are you sure you want to change the base?
Add Windows zip #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be OK in giving this a try for v0.83.0. I would like to avoid merging this for the next release though (0.82.0), as it has the potential to break the already late current release.
@jpkrohling Is it possible to merge it to the next version (0.84.0)? |
I'll close and open this PR again, in an attempt to retrigger the CI: it has failed with a disk space issue, which I'm hoping is not tied to this PR. |
@jpkrohling no space left on device |
Can you check what are the disk requirements before and after this change? Are we just too close to the limit on the main branch, or is this change here causing too much usage? |
@codeboten @jpkrohling I added |
@jpkrohling @codeboten all checks have passed... |
would you please look at the conflicts? |
Needs a rebase |
@ShiranAvidov please let us know if you would like to work to resolve conflicts on this PR, otherwise we will close it for inactivity in 30 days. |
I created a new Build and Archive for Windows, so each release will have Windows tar.gz and zip files.
#373