Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observability: consistent naming for metrics produced by OTel service #141

Closed
pjanotti opened this issue Jul 8, 2019 · 3 comments
Closed

observability: consistent naming for metrics produced by OTel service #141

pjanotti opened this issue Jul 8, 2019 · 3 comments

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Jul 8, 2019

Before first release we should make the name of metrics generated consistent, currently these are not consistent through the code base.
@tigrannajaryan tigrannajaryan self-assigned this Jul 16, 2019
@tigrannajaryan tigrannajaryan removed their assignment Sep 24, 2019
@ledor473
Copy link
Contributor

Would that include changing the namespace used for the metrics?

opentelemetry-collector/service/telemetry.go

Lines 86 to 88 in 7a6e5f1

opts := prometheus.Options{
Namespace: "oc_collector",
}

Currently we get the following metric:

oc_collector_otelcol_receiver_received_spans
oc_collector_otelcol_exporter_received_spans
...

@pjanotti
Copy link
Contributor Author

Yes, @ledor473 at least making it configurable: there is the case to keep the old one for people that have alerts/dashboards based on oc_collector but it makes sense to update the namespace.

@pjanotti pjanotti mentioned this issue Feb 4, 2020
Merged
This was referenced Feb 12, 2020
Merged
Merged
tigrannajaryan pushed a commit that referenced this issue Feb 18, 2020
Add the Observability Report Package (#544)
0a9e87f 
This package is going to allow controlled transition/rename of metrics.
The initial implementation just prepares the way to remove the calls to
the observability package.

In order to be able to rename and change the metrics generated by the Collector without breaking current usage the obsreport package is being introduced. After this is merged a command-line flag can be added to control the generation of the different sets of metrics - initially with the default as legacy only.

Link to tracking Issue: Needed for #141, see also the comments of PR #530

Testing: Besides the added tests I have a series of follow up PRs ready, I used these other PRs to manually validate the changes.

Documentation: Please refer to doc.go in the new package.
tigrannajaryan pushed a commit that referenced this issue Feb 20, 2020
Rename Processor Metrics (#551)
919adc0 
These metrics had an outdated prefix, while at it renamed the metrics attempting to make their meaning more obvious.

Link to tracking Issue: Related to #141

Testing: Manually validated generated metric names
This was referenced Feb 25, 2020
Merged
Merged
This was referenced Mar 10, 2020
Merged
Merged
Merged
tigrannajaryan pushed a commit that referenced this issue Mar 16, 2020
@pjanotti
Update processor metrics to obsreport (#606)
b9dc8ec 
Initial updates to migrate processor metrics to obsreport package, ie.: the new metrics.

Cleaned-up a bit some of the processor metrics and spelled out the rule names for new metrics.

Related to #141

Testing: Added test for the processor common metrics, validated manually that legacy metrics were still working
@bogdandrutu
Copy link
Member

I think this is covered by the transition to the new obsreport package.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@flands
Fix typo in README (open-telemetry#141)
faf0e7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ledor473 @bogdandrutu @tigrannajaryan @pjanotti