Migrate Prometheus receiver metrics to obsreport package #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
requested review from
bogdandrutu,
flands,
owais,
rghetia,
songy23 and
tigrannajaryan
as code owners
pjanotti
commented
Mar 11, 2020
| @@ -124,7 +124,8 @@ func (b *metricBuilder) AddDataPoint(ls labels.Labels, t int64, v float64) error | |||
| return b.currentMf.Add(metricName, ls, t, v) | |||
| } | |||
|
|
|||
| // Build is to build an opencensus data.MetricsData based on all added data complexValue | |||
| // Build is to build an opencensus data.MetricsData based on all added data complexValue. | |||
| // The only error returned by this function is errNoDataToBuild. | |||
There was a problem hiding this comment.
Later we should look at returning a bool instead of an error but didn't want to make a bigger change now.
pjanotti
commented
Mar 11, 2020
| github.com/open-telemetry/opentelemetry-proto v0.0.0-20200211051721-ff5f19c6217d h1:hZcHR0at6tb3jBjaPHlfLr6yK7rTrA8xGCS6jlUSLcU= | ||
| github.com/open-telemetry/opentelemetry-proto v0.0.0-20200211051721-ff5f19c6217d/go.mod h1:PMR5GI0F7BSpio+rBGFxNm6SLzg3FypDTcFuQZnO+F8= | ||
| github.com/open-telemetry/opentelemetry-proto v0.0.0-20200227223449-a65b867510c0/go.mod h1:PMR5GI0F7BSpio+rBGFxNm6SLzg3FypDTcFuQZnO+F8= | ||
| github.com/open-telemetry/opentelemetry-proto v0.0.0-20200308012146-674ae1c8703f h1:o21WlujGsrjoN3+n99AflASF/K0S6+SOLOj2O9nNplc= |
There was a problem hiding this comment.
This was updated on my env for a full build, took the chance to run go mod tidy
There was a problem hiding this comment.
Wouldn't it be better to send a separate PR for that?
owais
approved these changes
Mar 11, 2020
rghetia
approved these changes
Mar 11, 2020
tigrannajaryan
approved these changes
Mar 11, 2020
dinooliva
approved these changes
Mar 11, 2020
This is the minimal change to migrate the Prometheus metrics to the obsreport package (capable of generating both new and legacy metrics).
pjanotti
force-pushed
the
prom-receiver-metrics
branch
from
4111f60
to
65bb96c
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* othttp: add WithSpanFormatter option * plugin/othttp: add span formatter test * remove typo * preserve operation && change option name * nil check * fix comment typo Co-Authored-By: Rahul Patel <rghetia@yahoo.com> * add default formatter test case Co-authored-by: Rahul Patel <rghetia@yahoo.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#617) Bumps [boto3](https://github.com/boto/boto3) from 1.18.17 to 1.18.18. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.18.17...1.18.18) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This is a minimal change to migrate the Prometheus metrics to the obsreport package (capable of generating both new and legacy metrics).
Link to tracking Issue: Related to #141
Testing: Manual verification via docker-compose
Documentation: N/A