Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configtls] Rename configuration structs to end in Config and remove TLS prefix #9474

Closed
3 tasks done
mx-psi opened this issue Feb 6, 2024 · 1 comment · Fixed by #9495
Closed
3 tasks done

[configtls] Rename configuration structs to end in Config and remove TLS prefix #9474

mx-psi opened this issue Feb 6, 2024 · 1 comment · Fixed by #9495
Labels
area:config release:required-for-ga Must be resolved before GA release
Milestone
go.opentelemetry....

Comments

@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2024 •
edited

To be consistent with the recent changes in configgrpc and confighttp we should:

  • Rename configtls.TLSClientSetting to configtls.ClientConfig
  • Rename configtls.TLSServerSetting to configtls.ServerConfig
  • Rename configtls.TLSSetting to configtls.Config
@mx-psi mx-psi added release:required-for-ga Must be resolved before GA release area:config labels Feb 6, 2024
@bogdandrutu
Copy link
Member

Few others:

  • NetAddr -> AddrConfig?
  • NetTCP -> TCPConfig?

@arjunmahishi arjunmahishi mentioned this issue Feb 6, 2024
Merged
arjunmahishi added a commit to arjunmahishi/opentelemetry-collector that referenced this issue Feb 6, 2024
@arjunmahishi
[configtls] Rename config structs for consistancy
49a29fc 
This commit renames the following structs:

  * TLSClientSetting to ClientConfig
  * TLSServerSetting to ServerConfig
  * TLSSetting to Config

This is based on the naming convention followed in other config
packages.

Fixes open-telemetry#9474
@mx-psi mx-psi mentioned this issue Feb 7, 2024
Closed
arjunmahishi added a commit to arjunmahishi/opentelemetry-collector that referenced this issue Feb 7, 2024
@arjunmahishi
[configtls] Rename config structs for consistancy
88dfcf1 
This commit renames the following structs:

  * TLSClientSetting to ClientConfig
  * TLSServerSetting to ServerConfig
  * TLSSetting to Config

This is based on the naming convention followed in other config
packages.

Fixes open-telemetry#9474
arjunmahishi added a commit to arjunmahishi/opentelemetry-collector that referenced this issue Feb 7, 2024
@arjunmahishi
[configtls] Rename config structs for consistancy
6df20bc 
This commit renames the following structs:

  * TLSClientSetting to ClientConfig
  * TLSServerSetting to ServerConfig
  * TLSSetting to Config

This is based on the naming convention followed in other config
packages.

Fixes open-telemetry#9474
arjunmahishi added a commit to arjunmahishi/opentelemetry-collector that referenced this issue Feb 28, 2024
@arjunmahishi
[configtls] Rename config structs for consistancy
082dfaf 
This commit renames the following structs:

  * TLSClientSetting to ClientConfig
  * TLSServerSetting to ServerConfig
  * TLSSetting to Config

This is based on the naming convention followed in other config
packages.

Fixes open-telemetry#9474
dmitryax pushed a commit that referenced this issue Feb 29, 2024
@arjunmahishi
[configtls] Rename config structs for consistency (#9495)
9a83b0a 
**Description:** 
Simply renames a few structs in the `configtls` package for consistence.

`TLSClientSetting` to `ClientConfig`
`TLSServerSetting` to `ServerConfig`
`TLSSetting` to `Config`

**Link to tracking Issue:** Fixes #9474
@TylerHelmuth TylerHelmuth mentioned this issue Mar 18, 2024
Merged
mx-psi pushed a commit that referenced this issue Mar 27, 2024
@TylerHelmuth
[configtls] Removed deprecated structs (#9786)
1038b67 
**Description:** <Describe what has changed.>
Removed deprecated structs

**Link to tracking Issue:** <Issue number if applicable>
Related to
#9428
Related to
#9474
Closes
#9548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config release:required-for-ga Must be resolved before GA release
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/config/...
Development

Successfully merging a pull request may close this issue.

[configtls] Rename config structs for consistency arjunmahishi/opentelemetry-collector
2 participants
@bogdandrutu @mx-psi