Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp/configgrps] Rename the fields of types that were renamed in configtls #9548

Closed
arjunmahishi opened this issue Feb 10, 2024 · 0 comments · Fixed by #9786
Closed

[confighttp/configgrps] Rename the fields of types that were renamed in configtls #9548

arjunmahishi opened this issue Feb 10, 2024 · 0 comments · Fixed by #9786
Labels
area:config
Milestone
go.opentelemetry....

Comments

@arjunmahishi
Copy link
Contributor

arjunmahishi commented Feb 10, 2024 •
edited
Loading 

          We should at least open a PR about re-naming the variable as well.

Originally posted by @bogdandrutu in #9495 (comment)

As a part of #9495, some types in configtls were renamed to match the naming convention followed in other packages. But the fields/attributes that use those types were not renamed to maintain backward compatibility. Opening this PR to track that change.

Types that were renamed

  • TLSClientSetting to ClientConfig
  • TLSServerSetting to ServerConfig
  • TLSSetting to Config

These types are used with some struct attributes in the package confighttp and configgrpc.
@arjunmahishi arjunmahishi mentioned this issue Feb 10, 2024
Merged
@TylerHelmuth TylerHelmuth added release:required-for-ga Must be resolved before GA release and removed release:required-for-ga Must be resolved before GA release labels Feb 13, 2024
@TylerHelmuth TylerHelmuth mentioned this issue Mar 18, 2024
Merged
mx-psi pushed a commit that referenced this issue Mar 27, 2024
@TylerHelmuth
[configtls] Removed deprecated structs (#9786)
1038b67 
**Description:** <Describe what has changed.>
Removed deprecated structs

**Link to tracking Issue:** <Issue number if applicable>
Related to
#9428
Related to
#9474
Closes
#9548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/config/...
Development

Successfully merging a pull request may close this issue.

[configtls] Removed deprecated structs TylerHelmuth/opentelemetry-collector
2 participants
@arjunmahishi @TylerHelmuth