Change host metrics shutdown to use done channel #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
james-bebbington
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 189 189
Lines 13167 13167
=======================================
Hits 11273 11273
Misses 1441 1441
Partials 453 453
Continue to review full report at Codecov.
|
…n provided context's cancelFn to signal end of ticker
james-bebbington
force-pushed
the
hostmetrics-done-channel
branch
from
099675f
to
3ccd9c2
Compare
dmitryax
approved these changes
May 25, 2020
bogdandrutu
approved these changes
May 25, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…n provided context's cancelFn to signal end of ticker (open-telemetry#1017)
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…uration files (open-telemetry#1017) Migrate from legacy endpoint. The migration must be smooth because setting up default OTLP HTTP endpoint also enables the legacy one https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/otlpreceiver/otlp.go#L146-L157. Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to the host metrics receiver to not rely on the context provided in the Start method to determine when the host metrics ticker function should be terminated.
Addresses #974 (comment)