Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cpu load scraper #974

Merged

Conversation

james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented May 15, 2020

Link to tracking Issue:
#847

Description:
Added load scraper to the hostmetricsreceiver which:

  • On Unix-based systems, uses gopsutil to collect load metrics
  • On Windows, samples the "Processor Queue Length" performance counter over 5s intervals and computes similar load averages (similar to what psutil does)

Metrics:

image

@bogdandrutu
Copy link
Member

Please rebase, all imports changed :)

@codecov-commenter
Copy link

Codecov Report

Merging #974 into master will increase coverage by 0.06%.
The diff coverage is 96.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
+ Coverage   85.62%   85.69%   +0.06%     
==========================================
  Files         184      188       +4     
  Lines       13087    13148      +61     
==========================================
+ Hits        11206    11267      +61     
+ Misses       1434     1433       -1     
- Partials      447      448       +1     
Impacted Files Coverage Δ
...eiver/internal/scraper/loadscraper/load_scraper.go 92.00% <92.00%> (ø)
receiver/hostmetricsreceiver/factory.go 73.07% <100.00%> (+0.52%) ⬆️
...csreceiver/internal/scraper/loadscraper/factory.go 100.00% <100.00%> (ø)
...ver/internal/scraper/loadscraper/load_constants.go 100.00% <100.00%> (ø)
...nternal/scraper/loadscraper/load_scraper_others.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 76.47% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a637b41...fb2d7ec. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 36023bd into open-telemetry:master May 19, 2020
@flands flands added this to the Beta 0.4 milestone Jun 4, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants