-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging of component start errors #10440
Merged
mx-psi
merged 1 commit into
open-telemetry:main
from
swiatekm:fix/service/component-logging
Jul 18, 2024
Merged
Improve logging of component start errors #10440
mx-psi
merged 1 commit into
open-telemetry:main
from
swiatekm:fix/service/component-logging
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10440 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 403 403
Lines 18725 18733 +8
=======================================
+ Hits 17289 17297 +8
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
706f964
to
97a1013
Compare
97a1013
to
d9b7448
Compare
28f8868
to
7cc3eea
Compare
mx-psi
reviewed
Jul 18, 2024
7cc3eea
to
0a6609d
Compare
mx-psi
approved these changes
Jul 18, 2024
Can you fix CI? After that I am happy to merge this |
0a6609d
to
6157936
Compare
Rebased on main after #10661, should be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved logging of component start errors, so the log lines appear where they chronologically happen, rather than at the end. They also use the component logger, which makes them look nicer.
Output before change:
Output after change:
We've added the following line:
For extensions, the new line looks like so:
Link to tracking issue
Fixes #7078